Skip to content

fix: #199269 Caching Resource Requests #199270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yiliang114 wants to merge 1 commit into from
Closed

fix: #199269 Caching Resource Requests #199270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/vs/platform/extensionResourceLoader/browser/extensionResourceLoaderService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,14 @@ import { IProductService } from 'vs/platform/product/common/productService';
import { IStorageService } from 'vs/platform/storage/common/storage';
import { IEnvironmentService } from 'vs/platform/environment/common/environment';
import { ILogService } from 'vs/platform/log/common/log';
import { LRUCache } from 'vs/base/common/map';
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
import { AbstractExtensionResourceLoaderService, IExtensionResourceLoaderService } from 'vs/platform/extensionResourceLoader/common/extensionResourceLoader';

class ExtensionResourceLoaderService extends AbstractExtensionResourceLoaderService {

declare readonly _serviceBrand: undefined;
private readonly cache = new LRUCache<string, string>(100);

constructor(
@IFileService fileService: IFileService,
Expand All @@ -37,6 +39,10 @@ class ExtensionResourceLoaderService extends AbstractExtensionResourceLoaderServ
return result.value.toString();
}

if (this.cache.get(uri.toString(true))) {
return this.cache.get(uri.toString(true))!;
}

const requestInit: RequestInit = {};
if (this.isExtensionGalleryResource(uri)) {
requestInit.headers = await this.getExtensionGalleryRequestHeaders();
Expand All @@ -46,9 +52,13 @@ class ExtensionResourceLoaderService extends AbstractExtensionResourceLoaderServ
const response = await fetch(uri.toString(true), requestInit);
if (response.status !== 200) {
this._logService.info(`Request to '${uri.toString(true)}' failed with status code ${response.status}`);
this.cache.delete(uri.toString(true));
throw new Error(response.statusText);
}
return response.text();

const resp = await response.text();
this.cache.set(uri.toString(true), resp);
return resp;
}
}

Expand Down