Skip to content

inlay hints: fix: trace logging prints json-ified object not [object] #198511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulugbekna merged 1 commit into from
Nov 17, 2023
Merged

inlay hints: fix: trace logging prints json-ified object not [object] #198511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/vs/workbench/api/common/extHostLanguageFeatures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1364,7 +1364,7 @@ class InlayHintsAdapter {
const hints = await this._provider.provideInlayHints(doc, range, token);
if (!Array.isArray(hints) || hints.length === 0) {
// bad result
this._logService.trace(`[InlayHints] NO inlay hints from '${this._extension.identifier.value}' for ${ran}`);
this._logService.trace(`[InlayHints] NO inlay hints from '${this._extension.identifier.value}' for range ${JSON.stringify(ran)}`);
return undefined;
}
if (token.isCancellationRequested) {
Expand All @@ -1380,7 +1380,7 @@ class InlayHintsAdapter {
result.hints.push(this._convertInlayHint(hints[i], [pid, i]));
}
}
this._logService.trace(`[InlayHints] ${result.hints.length} inlay hints from '${this._extension.identifier.value}' for ${ran}`);
this._logService.trace(`[InlayHints] ${result.hints.length} inlay hints from '${this._extension.identifier.value}' for range ${JSON.stringify(ran)}`);
return result;
}

Expand Down