Skip to content

feature: allow to paste files from the clipboard #195730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lramos15 merged 19 commits into from
Nov 3, 2023
Merged

feature: allow to paste files from the clipboard #195730

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0b3ece7
feature: add basic file pasting (native)
SimonSiefke Oct 16, 2023
b4bf321
Merge branch 'microsoft:main' into simon/explorer-paste
SimonSiefke Oct 16, 2023
f516673
feature: allow native file pasting to coexist with explorer file pasting
SimonSiefke Oct 16, 2023
162d6d4
refactor: remove console log
SimonSiefke Oct 16, 2023
37ad321
undo-import-changes
SimonSiefke Oct 16, 2023
eb39970
fix: lint
SimonSiefke Oct 16, 2023
0679b07
refactor: move paste file handler to explorerView
SimonSiefke Oct 18, 2023
8c55be3
simplify code
SimonSiefke Oct 18, 2023
3b0fcb3
remove unused import
SimonSiefke Oct 18, 2023
19eab96
fix: handle files without path when running in web
SimonSiefke Oct 20, 2023
c686182
Merge branch 'main' into simon/explorer-paste
bpasero Oct 29, 2023
46d5f06
:lipstick:
bpasero Oct 29, 2023
5be58cc
feature: add paste confirmation dialog
SimonSiefke Nov 2, 2023
76f82a1
improve confirmation message
SimonSiefke Nov 2, 2023
7b8ba0f
Merge branch 'main' into simon/explorer-paste
SimonSiefke Nov 2, 2023
74fb1fc
feature: improve confirmation message when items are folders and not …
SimonSiefke Nov 2, 2023
9335de1
simplify code
SimonSiefke Nov 2, 2023
04fa3fc
simplify code
SimonSiefke Nov 2, 2023
676b59e
remove unused import
SimonSiefke Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions src/vs/workbench/contrib/files/browser/fileActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { toErrorMessage } from 'vs/base/common/errorMessage';
import { Action } from 'vs/base/common/actions';
import { dispose, IDisposable } from 'vs/base/common/lifecycle';
import { VIEWLET_ID, IFilesConfiguration, VIEW_ID, UndoConfirmLevel } from 'vs/workbench/contrib/files/common/files';
import { IFileService } from 'vs/platform/files/common/files';
import { IFileService, IFileStatWithPartialMetadata } from 'vs/platform/files/common/files';
import { EditorResourceAccessor, SideBySideEditor } from 'vs/workbench/common/editor';
import { IQuickInputService, ItemActivation } from 'vs/platform/quickinput/common/quickInput';
import { IInstantiationService, ServicesAccessor } from 'vs/platform/instantiation/common/instantiation';
Expand Down Expand Up @@ -1082,6 +1082,22 @@ CommandsRegistry.registerCommand({
handler: uploadFileHandler
});

const getConfirmMessage = (toPaste: readonly URI[], stats: readonly IFileStatWithPartialMetadata[]) => {
const isMultiple = toPaste.length > 1;
const isAllFolders = stats.every(stat => stat.isDirectory);
const isAllFiles = stats.every(stat => stat.isFile);
if (isMultiple) {
if (isAllFolders) {
return nls.localize('confirmMultiPasteNativeFolders', "Are you sure you want to paste the following {0} folders?", toPaste.length);
}
if (isAllFiles) {
return nls.localize('confirmMultiPasteNativeFiles', "Are you sure you want to paste the following {0} files?", toPaste.length);
}
return nls.localize('confirmMultiPasteNativeItems', "Are you sure you want to paste the following {0} items?", toPaste.length);
}
return nls.localize('confirmPasteNative', "Are you sure you want to paste '{0}'?", basename(toPaste[0].fsPath));
};

export const pasteFileHandler = async (accessor: ServicesAccessor, fileList?: FileList) => {
const clipboardService = accessor.get(IClipboardService);
const explorerService = accessor.get(IExplorerService);
Expand All @@ -1099,11 +1115,9 @@ export const pasteFileHandler = async (accessor: ServicesAccessor, fileList?: Fi
const toPaste = await getFilesToPaste(fileList, clipboardService);

if (confirmPasteNative) {
const message = toPaste.length > 1 ?
nls.localize('confirmMultiPasteNative', "Are you sure you want to paste the following {0} files?", toPaste.length) :
nls.localize('confirmPasteNative', "Are you sure you want to paste '{0}'?", basename(toPaste[0].fsPath));
const stats = await Promise.all(toPaste.map(uri => fileService.stat(uri)));
const message = getConfirmMessage(toPaste, stats);
const detail = toPaste.length > 1 ? getFileNamesMessage(toPaste) : undefined;

const confirmation = await dialogService.confirm({
message,
detail,
Expand Down