Conversation
alexdima
left a comment
alexdima
left a comment
There was a problem hiding this comment.
Looks good to me! I would suggest to try it out with a full build before merging.
This is syntax sugar around:
```
{ value localize('id', "Hello"), original: 'Hello' }
```
That will now be returned when you do:
```
localize2('id', "Hello");
```
TylerLeonhardt
force-pushed
the
tyler/domestic-emu
branch
from
e4134fe to
cba0802
Compare
|
Maybe bikeshedding, but is "localize2" the right name for this? To me |
|
Connor mentioned And Also, I think we can make bigger changes to the API when we align core with extension's |
* Introduce `localize2` function
This is syntax sugar around:
```
{ value localize('id', "Hello"), original: 'Hello' }
```
That will now be returned when you do:
```
localize2('id', "Hello");
```
* fix merge conflic
* new source map due to updated deps
4 participants
This is syntax sugar around:
That will now be returned when you do:
I tested this with a full build to ensure rewriting works as expected.