-
Notifications
You must be signed in to change notification settings - Fork 39.1k
feat: add code lens in sticky scroll widget #182950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
harbin1053020115
wants to merge
14
commits into
microsoft:main
from
harbin1053020115:feat/add-codelens-to-stickyscroll
Closed
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e629274
feat: add code lens in sticky scroll widget
alijs 5af5361
Merge branch 'main' into feat/add-codelens-to-stickyscroll
harbin1053020115 80305f4
Merge branch 'main' into feat/add-codelens-to-stickyscroll
alijs c9e53ce
fix: get the codelens startLineNumber for the first line of visible r…
alijs 92cb756
Merge branch 'main' into feat/add-codelens-to-stickyscroll
harbin1053020115 1bcc808
Merge branch 'main' into feat/add-codelens-to-stickyscroll
harbin1053020115 a3dce40
Merge branch 'main' into feat/add-codelens-to-stickyscroll
harbin1053020115 a5a6b07
Merge branch 'main' into feat/add-codelens-to-stickyscroll
harbin1053020115 8671f45
Merge branch 'main' into feat/add-codelens-to-stickyscroll
harbin1053020115 bae75e6
Merge branch 'main' into feat/add-codelens-to-stickyscroll
harbin1053020115 0db8533
Merge branch 'main' into feat/add-codelens-to-stickyscroll
harbin1053020115 5ad9dce
feat: merge main
alijs 177887c
Merge branch 'main' into feat/add-codelens-to-stickyscroll
harbin1053020115 29db317
Merge branch 'main' into feat/add-codelens-to-stickyscroll
harbin1053020115 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aiday-mar Is there a better way to compute the Code Lens's marginLeft?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As now I use renderViewLine to render spaces(according to the startColumn) before the Code Lens, which I think is not a lightweight solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VSCodeTriageBot Any one can handle this pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harbin1053020115 the team are in the middle of endgame, so I don't think this PR will get looked at until afterwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gjsjohnmurray You mean May 2023 Endgame(https://github.com/microsoft/vscode/issues/183504)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, #183504
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it~