Skip to content

improve references ariaLabel #182115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meganrogge merged 4 commits into from
May 12, 2023
Merged

improve references ariaLabel #182115

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54402b4
fix #180653
meganrogge May 10, 2023
5e5896e
Merge branch 'main' into merogge/ref
meganrogge May 12, 2023
1aa7cbd
revert change
meganrogge May 12, 2023
e21807d
one more revert
meganrogge May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/vs/editor/contrib/gotoSymbol/browser/referencesModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,13 @@ export class OneReference {

if (!preview) {
return localize(
'aria.oneReference', "symbol in {0} on line {1} at column {2}",
'aria.oneReference', "in {0} on line {1} at column {2}",
basename(this.uri), this.range.startLineNumber, this.range.startColumn
);
} else {
return localize(
{ key: 'aria.oneReference.preview', comment: ['Placeholders are: 0: filename, 1:line number, 2: column number, 3: preview snippet of source code'] }, "symbol in {0} on line {1} at column {2}, {3}",
basename(this.uri), this.range.startLineNumber, this.range.startColumn, preview.value
{ key: 'aria.oneReference.preview', comment: ['Placeholders are: 0: filename, 1:line number, 2: column number, 3: preview snippet of source code'] }, "{0} in {1} on line {2} at column {3}",
preview.value, basename(this.uri), this.range.startLineNumber, this.range.startColumn
);
}
}
Expand Down