add go to command for terminal accessible buffer
#177110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
Mar 14, 2023
meganrogge
changed the title
go to symbol for terminal accessible buffergo to command for terminal accessible buffer
meganrogge
commented
Mar 14, 2023
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Show resolved
Hide resolved
meganrogge
commented
Mar 14, 2023
...rkbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
Show resolved
Hide resolved
Member
I'm not aware of this, sounds like a separate issue though. I'd expect it to reproduce when using cmd+up/down to navigate between commands? |
Tyriar
requested changes
Mar 14, 2023
...rkbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Outdated
Show resolved
Hide resolved
Comment on lines
120
to
122
| if (this._inQuickPick) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Why is this needed? I wouldn't expect the editor to get focused when the quick pick is up, and if it was, wouldn't it hide?
Tyriar
previously approved these changes
Mar 15, 2023
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Outdated
Show resolved
Hide resolved
…/terminalAccessibleBuffer.ts Co-authored-by: Daniel Imms <[email protected]>
Tyriar
approved these changes
Mar 15, 2023
This was referenced Mar 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #174079