Skip to content

fix: typos #158431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzhao271 merged 1 commit into from
Nov 30, 2022
Merged

fix: typos #158431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/vs/workbench/contrib/extensions/browser/extensionEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ export class ExtensionEditor extends EditorPane {
if (extension.dependencies.length) {
template.navbar.push(ExtensionEditorTab.Dependencies, localize('dependencies', "Dependencies"), localize('dependenciestooltip', "Lists extensions this extension depends on"));
}
if (manifest && manifest.extensionPack?.length && !this.shallRenderAsExensionPack(manifest)) {
if (manifest && manifest.extensionPack?.length && !this.shallRenderAsExtensionPack(manifest)) {
template.navbar.push(ExtensionEditorTab.ExtensionPack, localize('extensionpack', "Extension Pack"), localize('extensionpacktooltip', "Lists extensions those will be installed together with this extension"));
}

Expand Down Expand Up @@ -818,7 +818,7 @@ export class ExtensionEditor extends EditorPane {

let activeElement: IActiveElement | null = null;
const manifest = await this.extensionManifest!.get().promise;
if (manifest && manifest.extensionPack?.length && this.shallRenderAsExensionPack(manifest)) {
if (manifest && manifest.extensionPack?.length && this.shallRenderAsExtensionPack(manifest)) {
activeElement = await this.openExtensionPackReadme(manifest, readmeContainer, token);
} else {
activeElement = await this.openMarkdown(this.extensionReadme!.get(), localize('noReadme', "No README available."), readmeContainer, WebviewIndex.Readme, token);
Expand All @@ -828,7 +828,7 @@ export class ExtensionEditor extends EditorPane {
return activeElement;
}

private shallRenderAsExensionPack(manifest: IExtensionManifest): boolean {
private shallRenderAsExtensionPack(manifest: IExtensionManifest): boolean {
return !!(manifest.categories?.some(category => category.toLowerCase() === 'extension packs'));
}

Expand Down
4 changes: 2 additions & 2 deletions src/vs/workbench/contrib/extensions/browser/extensionRecommendations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
*--------------------------------------------------------------------------------------------*/

import { Disposable } from 'vs/base/common/lifecycle';
import { IExtensionRecommendationReson } from 'vs/workbench/services/extensionRecommendations/common/extensionRecommendations';
import { IExtensionRecommendationReason } from 'vs/workbench/services/extensionRecommendations/common/extensionRecommendations';

export type ExtensionRecommendation = {
readonly extensionId: string;
readonly reason: IExtensionRecommendationReson;
readonly reason: IExtensionRecommendationReason;
};

export abstract class ExtensionRecommendations extends Disposable {
Expand Down
4 changes: 2 additions & 2 deletions src/vs/workbench/services/extensionRecommendations/common/extensionRecommendations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const enum ExtensionRecommendationReason {
Application,
}

export interface IExtensionRecommendationReson {
export interface IExtensionRecommendationReason {
reasonId: ExtensionRecommendationReason;
reasonText: string;
}
Expand All @@ -35,7 +35,7 @@ export interface IExtensionRecommendationsService {
readonly _serviceBrand: undefined;

readonly onDidChangeRecommendations: Event<void>;
getAllRecommendationsWithReason(): IStringDictionary<IExtensionRecommendationReson>;
getAllRecommendationsWithReason(): IStringDictionary<IExtensionRecommendationReason>;

getImportantRecommendations(): Promise<string[]>;
getOtherRecommendations(): Promise<string[]>;
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/services/language/common/languageService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ export class WorkbenchLanguageService extends LanguageService {
Object.keys(configuration.files.associations).forEach(pattern => {
const langId = configuration.files.associations[pattern];
if (typeof langId !== 'string') {
this.logService.warn(`Ingnoing configured 'files.associations' for '${pattern}' because its type is not a string but '${typeof langId}'`);
this.logService.warn(`Ignoring configured 'files.associations' for '${pattern}' because its type is not a string but '${typeof langId}'`);

return; // https://github.com/microsoft/vscode/issues/147284
}
Expand Down