Skip to content

Conversation

@alexr00
Copy link
Member

@alexr00 alexr00 commented Jan 7, 2021

This change allows remote extension to handle elevation if they want.
Fixes microsoft/vscode-remote-release#3922

@alexr00 alexr00 merged commit a7cf03d into master Jan 7, 2021
@alexr00 alexr00 deleted the alexr00/tunnelElevation branch January 7, 2021 15:21
@SamuelMoraesF
Copy link

SamuelMoraesF commented Feb 17, 2021

Is there anything that I need do to get this working? I'm currently using vscode insiders and I still can't forward lower ports (like 80 and 443).

@alexr00
Copy link
Member Author

alexr00 commented Feb 17, 2021

@SamuelMoraesF This change just added an option for Remote extensions to support using privileged ports. There are currently no Remote extensions that have done the necessary implementation to add this support. Which remote extension are you using?

@jfeliciani
Copy link

@alexr00 I have the same problem currently and really need this feature. I am currently using the Microsoft Remote - SSH extension. https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-ssh

@SamuelMoraesF
Copy link

@alexr00 I'm using docker containers (ms-vscode-remote.remote-containers)

@alexr00
Copy link
Member Author

alexr00 commented Feb 22, 2021

@chrmarti and @roblourens FYI there are requests to use privileged local ports when doing port forwarding in remote containers. To accomplish this, you would need to implement a tunnelFactory in each extension that knows how to elevate. Maybe this is an argument that would should support this in the core.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2021
@chrmarti
Copy link
Collaborator

chrmarti commented Mar 3, 2021

@alexr00 When the resolver does not have a tunnel factory, could the core implement elevation? Maybe there is also a way to share that with the tunnel factory if there is one. (Remote-Containers currently does not have a tunnel factory.)

@alexr00
Copy link
Member Author

alexr00 commented Mar 3, 2021

That should be possible. Feature request: microsoft/vscode-remote-release#4589

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port forwarding: when the local port is privileged, offer to elevate and use the privileged port if possible

5 participants