Update to 1.82.0, VSCode takes more time to kill processes after quit

[hua03]

Type: Bug

In this video, I quit VSCode at 7 seconds, but it (Dock Icon) was killed at 12 seconds.

2023-09-11.15.15.06.mov

VS Code version: Code 1.82.0 (8b617bd, 2023-09-06T22:09:41.364Z)
OS version: Darwin x64 22.5.0
Modes:

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz (8 x 2000)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	3, 3, 3
Memory (System)	32.00GB (13.43GB free)
Process Argv	--crash-reporter-id 25337f27-0fd6-4ad2-a343-d23e45e01d53
Screen Reader	no
VM	0%

Extensions (2)

Extension	Author (truncated)	Version
astro-vscode	ast	2.3.3
vscode-language-pack-zh-hans	MS-	1.82.2023090609

A/B Experiments

vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
vsccc:30803844
2e4cg342:30602488
f6dab269:30613381
2i9eh265:30646982
showlangstatbar:30737416
0bi6i642:30831757
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30797651
pythonidxptcf:30805731
pythonnoceb:30805159
dsvsc013:30795093
dsvsc014:30804076
diffeditorv1:30821571
dsvsc015:30829745

[jungaretti]

#192753 and #172967 include lots of information about this bug

[deepak1556]

Initial findings:

• Main process is delayed waiting on the shutdownPromise to resolve.
• Delay comes from exiting long running extension host in waitForExit
• Profiling the extension host shows that the Node.js is delayed in its cleanup of exit callbacks at https://github.com/nodejs/node/blob/b45e196bec407c9db30ffe5490bb86be692a1579/src/env.cc#L1180-L1186
• ⚠️ Disabling telemetry resolves the slow shutdown of the extension host "telemetry.telemetryLevel": "off"

@bpasero @lramos15 this is a return of #172967 but we have reliable repro this time. @lramos15 do we run any telemetry network requests from inside the extension host, if so can you point me to the code.