Error Telemetry has errors from processes run inside the extension that may contain PII

[ramya-rao-a]

[jrieken]

This might actually be me... I places I call the onUnexpectedError-method. Mostly, when I invoke a language feature provider that fails, like so. Do those error end up in telemetry or do they just get locked on the console as in dev?

[ramya-rao-a]

Yes, the errors do end up in telemetry.

The Error telemetry service gets instantiated for every workbench here

The Error telemetry service in turn adds a listener to the unexpectederrors . This listener logs the telemetry for the unexpected errors.

Example:
Command failed: /*****/go/bin/gocode -f=json autocomplete /****/go/main.go c839 /*******/go/bin/gocode: /*******/go/bin/gocode: cannot execute binary file

The tool gocode is run in a child node process by the Go extension to get completion items

[ramya-rao-a]

I'll add an onUnexpectedExternalError that does not call the listeners. Using this in place of onUnexpectedError in the language feature providers should ensure that errors get logged to console but do not end up in the telemetry.
Thoughts?

[jrieken]

I like