Custom protocols aggressively cache subresources

[jrieken]

• run scripts/code.sh
• change a CSS file
• reload window
• CSS change isn't reflected

Screen.Recording.2022-05-02.at.11.31.12.mov

[deepak1556]

Reloading uses the same process causing the css files to be cached. Disabling cache in network tab or reloading via devtools (Cmd + R) which uses a different code path will bypass this cache. I wonder if adding a Last-Modified header from Electron's custom protocol handler could be a viable solution when running OSS.

[deepak1556]

Aggressive caching for subresources is intended in the runtime https://bugs.chromium.org/p/chromium/issues/detail?id=654378#c4 and the only way to force revalidation is via Cache-Control: max-age=0 or Last-Modified headers. Do we want to add this workaround for OSS css resources ?

[jrieken]

I'd say so but we can also discuss in the team. Today's workaround is to disable caching which has the same effect but is a trick that you need to know

[bpasero]

I somehow hit this more often lately, can we do something OSS to address this @deepak1556 ?

[deepak1556]

@bpasero does the headers specified here #148541 (comment) help ? you can pass them via

vscode/src/vs/platform/protocol/electron-main/protocolMainService.ts

Line 94 in ec8a019

private handleResourceRequest(request: Electron.ProtocolRequest, callback: ProtocolCallback): void {