Crash reporter should not attach to terminalProcess

[michelleangela]

• VS Code Version:
  Version: 1.54.1
  Commit: f30a9b7
  Date: 2021-03-04T22:45:03.974Z
  Electron: 11.3.0
  Chrome: 87.0.4280.141
  Node.js: 12.18.3
  V8: 8.7.220.31-electron.0
  OS: Darwin arm64 20.2.0

• OS Version: macOS 11.1 Big Sur

Pre-requisite:

• clang++ is installed on macOS ARM64 (or install xcode)

Steps to Reproduce:

1. Create a simple cpp source file that crashes.
   Example code that crashes:

#include <iostream>

int main()
{
#if __arm64
std::cout << "arm64" << std::endl;
#endif

    std::cout << "test crash" << std::endl;
    long *p = 0; 
    *p = 0xFFFFFFFF;
    return 0;
}

2. compile cpp source file with clang++
3. run compiled executable from VS Code terminal shell zsh.
4. executable should crash and crash dump should be reported under ~/Library/Logs/DiagnosticReports

Actual result:
no crash dump reported under ~/Library/Logs/DiagnosticReports

Expected result:
crash dump reported under ~/Library/Logs/DiagnosticReports

Note:
When running the sample executable from regular macOS terminal, crash dumps are reported.

Does this issue occur when all extensions are disabled?: Yes

[Colengms]

Note that this repro's with any child process in VS Code's process tree. We see that a native process launched by our extension is not getting processed by macOS only on Mac ARM. The repro in VS Code's terminal seemed like a simpler repo of the same issue.

Possibly related is the long-standing issue that Electron was not capturing crashes of child processes. That appears to recently have been fixed? electron/electron#22552 If so, it's unclear why we are seeing child processes launched by VS Code's terminal getting captured only on Mac ARM, while still getting processed by the OS when using a Mac x64 build of the same version of VS Code.

If the Electron issue is indeed fixed, and child process crashes are being intercepted by Electron, please let us know how to enroll in whatever process will now be gathering our crashes. We have been relying on these crashes being handled by the OS so we can collect these stacks from reports logged by the OS.

[deepak1556]

Child process are now monitored by the crash handler from runtime, you can obtain the reports following the steps https://github.com/microsoft/vscode/wiki/Native-Crash-Issues#creating-and-symbolicating-local-crash-reports. Once the app is quit, the crash report will be under <crash-reporter-directory>/pending. To symbolicate, you can use https://github.com/nornagon/electron-minidump/blob/master/README.md and the symbols need to generated in the following format https://github.com/google/breakpad/blob/master/README.ANDROID#L93-L113. I will update the documentation on this in the wiki.

You can always disable the electron crash handler as an alternative, following these steps:

* Start the app with --disable-crash-reporter

or

* Open Command Palette
* Configure Runtime Arguments
* "enable-crash-reporter": false

[Colengms]

Hi @deepak1556 . Note that this issue is not related to child processes launched by VS Code itself or an extension. This issue occurs when the user launches unrelated processes from the Terminal. I would not expect those to be handled by the crash reporter.

[deepak1556]

That is a side effect of shell process being launched from vscode https://github.com/microsoft/vscode/blob/main/src/vs/platform/terminal/node/terminalProcess.ts#L198, the crash handler will attach to it. There is no way in the runtime currently to ignore a particular process, until it is fixed the above workaround should be utilized.