Improve debug self hosting experience

[isidorn]

Most notable with regards to debugging vscode.

[isidorn]

Also assinging to @weinand since the large self hosting compound debugs everything inlcuding EH debugging

[isidorn]

Related issue filled by @joaomoreno #83994
fyi @deepak1556 and @roblourens since they are assigned to that issue
@jrieken says it is very flaky and issues are not reproducable in general

I will self host on it more in the following days and hopefully can idenity issues that are paper cuts.

[jrieken]

Yes, using the "VS Code" launch config is very frustrating. There are many UX paper cuts like notification spam, questionable debug console selection, disconnect vs stop button etc pp. However, there is also severe trouble where things freeze or crash and that seems to happen 2 out of 3 times and only when a breakpoint is set here but not there or when a console message appears at a bad time or what not. This seems soo random that I cannot file a bug that would meet my personal bug min bar and that's read sad part of this. I have no clue how to help to improve this.

[isidorn]

Following down the issue links, this seems to be the issue on the Electron side for the random crashes electron/electron#21288
As for other papercuts we can look into fixing them on the vscode side.

[jrieken]

Following down the issue links, this seems to be the issue on the Electron side for the random crashes electron/electron#21288

No. I know about the break-on-async-problem but this is a head to head comparison with devtools and vscode and while I can happily work with the former I cannot with the latter.

[roblourens]

One issue that I repro often is that if the renderer process console.logs a lot while vscode is attached, it will hang. Doesn't happen when only attached with devtools.

[connor4312]

@jrieken please file issues for me when you run into a papercut or problem, even if you run into a issue you can't consistently reproduce. You can also add trace: true to your launch configuration locally so that you have a log available whenever you run into a problem. (The location of the log file for each run will be printed to the debug console.) My bug queue for js-debug is almost empty right now, I need to know about issues in order to fix them! 🙂

disconnect vs stop button etc

This should be better with #99736

notification spam, questionable debug console selection

Can you expand on these? Either here or a new issue is good.

things freeze or crash

I think Eric has also seen these. I can only assume this is some problem in Electron. I have not observed the extension host/node/chrome freezing in that way. I'll try to play around and reproduce it locally, a trace: true log would also help if you're able to capture it easily.

One issue that I repro often is that if the renderer process console.logs a lot while vscode is attached, it will hang

I think we fixed this yesterday with: microsoft/vscode-js-debug@154a62d I'll make a console spam extension to try to verify

[jrieken]

Can you expand on these? Either here or a new issue is good.

Whenever something doesn't work, e.g because there is still a dangling process or so, things go wild. Simulate the worst of it like so:

• in the terminal run script/code.sh
• from debug launch "VS Code"
• a monster 🌊 of model dialogs and notifications heading to you

I know this is a tricky one and my sample is the worst case but when something fails it's enough to say that once.

[connor4312]

That'll be fixed in the next nightly microsoft/vscode-js-debug@c462b53

[joaomoreno]

I often get into this rut: reloading the window stays like this forever. Further reloadings behave the same. I am forced to close the window.

Once I close the window, I wait for all debug sessions to terminate, which they do. But then when I F5 again I get:

At this point I look for running processes:

➜  vscode git:(joao/scm-view) ✗ ps ax | grep code-oss
27213 ?        Sl     0:00 /home/joao/Work/vscode/.build/electron/code-oss --nolazy --inspect=6044 /home/joao/Work/vscode/extensions/json-language-features/server/out/node/jsonServerMain --node-ipc --clientProcessId=27013

So I kill 'em: killall code-oss. Then it works. 🤷