Skip to content

Commit 1189f13

Browse files
committed
chore: revert ci changes for node v16
1 parent abf2afe commit 1189f13

File tree

2 files changed

+2
-20
lines changed

2 files changed

+2
-20
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,7 @@ jobs:
5757
env:
5858
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
5959
ELECTRON_SKIP_BINARY_DOWNLOAD: 1
60-
run: |
61-
# update node-gyp to latest for support in detecting VS 2022 toolchain
62-
npm install -g node-gyp@latest
63-
# Resolve to node-gyp.js
64-
# Remove this once node-version > 17.4.x or > 16.14.0,
65-
# which ships with npm > 8.4.0 that has support for VS 2022 toolchain.
66-
$env:npm_config_node_gyp=$(Join-Path $(Get-Command node-gyp.cmd).Path "..\node_modules\node-gyp\bin\node-gyp.js" -Resolve)
67-
yarn --frozen-lockfile --network-timeout 180000
60+
run: yarn --frozen-lockfile --network-timeout 180000
6861
- name: Create node_modules archive
6962
if: ${{ steps.cacheNodeModules.outputs.cache-hit != 'true' }}
7063
run: |

.github/workflows/rich-navigation.yml

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,7 @@ jobs:
2828

2929
- name: Install dependencies
3030
if: steps.caching-stage.outputs.cache-hit != 'true'
31-
run: |
32-
# update node-gyp to latest for support in detecting VS 2022 toolchain
33-
npm install -g node-gyp@latest
34-
# Resolve to node-gyp.js
35-
# Remove this once node-version > 17.4.x or > 16.14.0,
36-
# which ships with npm > 8.4.0 that has support for VS 2022 toolchain.
37-
$env:npm_config_node_gyp=$(Join-Path $(Get-Command node-gyp.cmd).Path "..\node_modules\node-gyp\bin\node-gyp.js" -Resolve)
38-
# Electron <= 13 does not ship with correct config.gypi headers,
39-
# remove this once we update to newer versions.
40-
# Refs https://github.com/nodejs/node-gyp/pull/2497
41-
$env:npm_config_force_process_config="true"
42-
yarn --frozen-lockfile
31+
run: yarn --frozen-lockfile
4332
env:
4433
CHILD_CONCURRENCY: 1
4534

0 commit comments

Comments
 (0)