Skip to content

Commit abf2afe

Browse files
committed
Revert "ci: fix build with latest node-gyp"
This reverts commit c3e948a.
1 parent b52ead2 commit abf2afe

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,6 @@ jobs:
6464
# Remove this once node-version > 17.4.x or > 16.14.0,
6565
# which ships with npm > 8.4.0 that has support for VS 2022 toolchain.
6666
$env:npm_config_node_gyp=$(Join-Path $(Get-Command node-gyp.cmd).Path "..\node_modules\node-gyp\bin\node-gyp.js" -Resolve)
67-
# Electron <= 13 does not ship with correct config.gypi headers,
68-
# remove this once we update to newer versions.
69-
# Refs https://github.com/nodejs/node-gyp/pull/2497
70-
$env:npm_config_force_process_config="true"
7167
yarn --frozen-lockfile --network-timeout 180000
7268
- name: Create node_modules archive
7369
if: ${{ steps.cacheNodeModules.outputs.cache-hit != 'true' }}

build/azure-pipelines/darwin/product-build-darwin.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,6 @@ steps:
7979
set -e
8080
export npm_config_arch=$(VSCODE_ARCH)
8181
export npm_config_node_gyp=$(which node-gyp)
82-
# Electron <= 13 does not ship with correct config.gypi headers,
83-
# remove this once we update to newer versions.
84-
# Refs https://github.com/nodejs/node-gyp/pull/2497
85-
export npm_config_force_process_config=true
8682
8783
for i in {1..3}; do # try 3 times, for Terrapin
8884
yarn --frozen-lockfile && break

0 commit comments

Comments
 (0)