Skip to content

Fixes #201: Command callback not receiving WASM returned data when in Worker #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbaeumer merged 1 commit into from
Oct 2, 2024
Merged

Fixes #201: Command callback not receiving WASM returned data when in Worker #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions wasm-component-model/src/common/componentModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1886,12 +1886,18 @@ abstract class TypeArrayType<T extends { length: number; byteLength: number }, E
dest.assertAlignment(dest_offset, this.alignment);
src.assertAlignment(src_offset, this.alignment);
const offsets = TypeArrayType.offsets;
src.copyBytes(src_offset, this.size, dest, dest_offset);
// read data pointer and length for the src data
const data = src.getUint32(src_offset + offsets.data);
const byteLength = src.getUint32(src_offset + offsets.length) * this.elementType.size;
const length = src.getUint32(src_offset + offsets.length);
const byteLength = length * this.elementType.size;
const srcReader = src.memory.readonly(data, byteLength);
// Allocate space in dest for the data
const destWriter = dest.memory.alloc(this.elementType.alignment, byteLength);
// Copy the byes over
srcReader.copyBytes(0, byteLength, destWriter, 0);
// Store the new data pointer and length in dest
dest.setUint32(dest_offset + offsets.data, destWriter.ptr);
dest.setUint32(dest_offset + offsets.length, length);
}

public copyFlat(result: WasmType[], dest: Memory, values: FlatValuesIter, src: Memory, _context: ComponentModelContext): void {
Expand Down