feat: --packageManager
#1226
Open
feat: --packageManager
#1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed at further addressing issues with package managers. It introduces a distinction between different package managers by creating an internal API and making several stylistic changes that simplify supporting this API in the future. I do not intend to create a separate PR for the stylistic changes even if asked.
This internal API could be used to build a public API, but that is not part of my plans.
It should also be noted that the new --packageManager flag could replace the existing --yarn, --no-yarn, and --dependencies options in any upcoming major release. Removing the deprecated API is also not part of my plans. This PR makes minor changes that could potentially break something, and in such cases patches should be created. I am willing to help with those patches.
I am having trouble running the tests. Apparently they are broken, or I broke them. Assistance with this would be helpful.
SyntaxError: The angle-bracket syntax for type assertions, `<T>expr`, is not supported in type strip mode. Instead, use the 'as' syntax: `expr as T`.