Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Conversation

@vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Apr 20, 2020

AB#34667

Description:

  • Added Table of Contents for README
  • Purposely didn't include some parts because I didn't want to clutter the table of contents (eg. build status, every step for how to use) but let me know your opinions.

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!
LGTM


## Devices we support:
## Table of Contents
- [Devices we support](#devices-we-support)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know how the table of contents will work in the marketplace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! The links are markdown links and we have some in the marketplace already for "devices we support". Clicking on a device takes you to the device part in the marketplace :)

Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU! much needed

@vandyliu vandyliu merged commit 48f817b into dev Apr 20, 2020
@vandyliu vandyliu deleted the users/t-vali/toc branch April 20, 2020 22:59
andreamah added a commit that referenced this pull request Apr 21, 2020
* Add precision to input slider

* Fix inverse switch

* Refactor

* Switch default is false

* Modify precision value for cpx and clue

* Table of Contents for README (#349)

* Slideshow Backwards/Forwards Bug Fix (#350)

* slideshow nav fixed

* Fixed print() statements for CLUE display in debug mode (#351)

* fixed debug_user_code.py to capture print statements

* added starting and ending print statements

* new release note apr 21

* added a few fixes

Co-authored-by: Vandy Liu <[email protected]>
Co-authored-by: Andrea Mah <[email protected]>
Co-authored-by: andreamah <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants