Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Conversation

@andreamah
Copy link
Contributor

Description:

When testing this test: https://github.com/adafruit/Adafruit_CircuitPython_CLUE/blob/master/examples/clue_slideshow.py, I found that there should be a public field in CLUE for the display. I made the small change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Testing:

https://github.com/adafruit/Adafruit_CircuitPython_CLUE/blob/master/examples/clue_slideshow.py

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@vandyliu vandyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took a while but it was worth the read. I learned a lot. Great change!

@andreamah andreamah merged commit 66ae2b4 into dev Apr 9, 2020
@andreamah andreamah deleted the users/t-anmah/clue-display-public-field branch April 9, 2020 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants