Microbit Debugger Fix

[andreamah]

Description:

Currently, the microbit does not respond to sensor/button input in debug mode.

This is because the handle to the microbit model instance is different in debugger_communication_client.py compared to everywhere else. Since micropython and microbit are both packages (although microbit is inside of the micropython package), instances imported as from microbit.__model.microbit_model import __mb as mb and from micropython.microbit.__model.microbit_model import __mb as mb deal with two different instances of mb. As a result, the mb that was getting an updated state was different than the one being referenced by the user code.

Type of change

• Bug fix (non-breaking change which fixes an issue)

Testing:

Simple code using any sensors/buttons in DEBUG MODE such as this:

from microbit import *

while True:
    if button_a.is_pressed():
        display.show(Image.HAPPY)
    else:
        display.show(Image.HEART)

Checklist:

• My code follows the style guidelines of this project
• My code has been formatted with npm run format and passes the checks in npm run check
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[nasadigital]

Great catch! LGTM!

[xnkevinnguyen]

LGTM! Thanks for fixing it

[nasadigital]

I would put this comment above the line it's referring to (or maybe remove the line break on line 20).
Now it seems as if it's referring to the next three lines where we calculate the path.

[nasadigital]

Just curious, if we used relative paths would the tests use the correct library?