test: add missing test coverage for PRs #684, #687, #706 - #767
Merged
Conversation
…s to #687) Tests the updateScore behavior introduced in PR #687: - Numeric score displays formatted score text - Undefined score (lintingStarted) shows loading spinner - Score of -1 (lintingFailed) shows error state - Non-active document score update does not change display - Zero score displays correctly Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Tests that checkIfConfigurationChanged correctly detects changes to all tracked configuration settings and returns false for unrelated settings. Note: PR #706 also added getServerEnabled and serverEnabled to the tracked settings list, but those changes are not present in the current codebase. Tests cover only the currently implemented behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
edvilme
changed the title
rchiodo
reviewed
Apr 1, 2026
rchiodo
previously approved these changes
Apr 1, 2026
rchiodo
left a comment
rchiodo
left a comment
Contributor
There was a problem hiding this comment.
Approved via Review Center.
Extract getTrackedSettings() from checkIfConfigurationChanged() so the test imports the canonical list instead of maintaining a hardcoded copy. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rchiodo
reviewed
Apr 2, 2026
Replace assert.include with assert.strictEqual for tooltip checks to match the pattern used by all other tooltip assertions in the file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rchiodo
reviewed
Apr 2, 2026
rchiodo
approved these changes
Apr 2, 2026
rchiodo
left a comment
rchiodo
left a comment
Contributor
There was a problem hiding this comment.
Approved via Review Center.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing test coverage for merged PRs, as tracked by #765.
Part of the cross-repo test coverage initiative: microsoft/vscode-python-tools-extension-template#290
Tests added
PR #684 — Python version boundary
python.unit.test.ts: Rejects Python 3.9 (both envs and legacy paths); accepts Python 3.10 minimumPR #687 — Status bar loading/error states
status.unit.test.ts: Loading spinner, error state, normal score display, non-active document handling, zero scorePR #706 — checkIfConfigurationChanged
settings.unit.test.ts: All tracked settings trigger change detection; unrelated settings return falseSkipped PRs
Refs #765