fix. template files should use UTF8 encoding other than UTF8 BOM#236
Merged
albertli-msft merged 1 commit intomainfrom Feb 17, 2023
Merged
fix. template files should use UTF8 encoding other than UTF8 BOM#236albertli-msft merged 1 commit intomainfrom
albertli-msft merged 1 commit intomainfrom
Conversation
mattmasson
approved these changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template files should be encoded in UTF8 other than UTF8 w/ BOM.
UTF8-BOM would prefix a zero width no-break space, 0xEF 0xBB 0xBF, at the beginning of the file for editors to more reliably to tell whether the file is encoded in UTF8 or not.
https://www.compart.com/en/unicode/U+FEFF
And it would cause problem when we need to directly handle the whole file over to the parser. Either we have to trim white spaces manually or we have to tell whether file is encoded of BOM.
So, I suggested encode all files in UTF8 by default for simplicity.