Replace hand-rolled typings with @vscode/python-environments npm package#467
Merged
Replace hand-rolled typings with @vscode/python-environments npm package#467
Conversation
Fixes #466 Co-authored-by: Copilot <[email protected]>
This was referenced Apr 1, 2026
edvilme
added a commit
that referenced
this pull request
Apr 1, 2026
…n (refs #496, relates to #467) Co-authored-by: Copilot <[email protected]>
edvilme
added a commit
that referenced
this pull request
Apr 7, 2026
* test: add coverage for nearestConfig with .mypy.ini, pyproject.toml, setup.cfg (refs #496, relates to #357) Co-authored-by: Copilot <[email protected]> * test: add coverage for global settings defaults including ignorePatterns and daemonStatusFile (refs #496, relates to #325, #347) Co-authored-by: Copilot <[email protected]> * test: add coverage for daemonStatusFile in _get_dmypy_args (refs #496, relates to #347) Co-authored-by: Copilot <[email protected]> * test: add coverage for daemonStatusFile in TS settings and checkIfConfigurationChanged (refs #496, relates to #347) Co-authored-by: Copilot <[email protected]> * test: add coverage for PythonEnvironments.api() interpreter resolution (refs #496, relates to #467) Co-authored-by: Copilot <[email protected]> * style: fix prettier formatting in settings.unit.test.ts * fix: address review comments - add missing mock attrs, try/finally cleanup - Add normalize_path to mock_lsp_utils in test_global_defaults.py - Add fallback guard ensuring normalize_path is set even if lsp_utils was mocked by another test file first - Wrap dmypy status file test bodies in try/finally so _clear_dmypy_cache() runs even when assertions fail Co-authored-by: Copilot <[email protected]> * fix: address review comments — unused imports, assertion, const - Remove unused imports (PythonEnvironmentApi, commands, Disposable, Event) - Add explicit envsApiStub.calledOnce assertion in fallback test - Change let workspace1 to const (2 occurrences) Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the manual \src/typings/pythonEnvironments.d.ts\ type declarations and \�xtensions.getExtension()\ activation pattern with the official @vscode/python-environments\ npm package.
Changes
Fixes #466