Skip to content

allow schema to be deprecated #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aeschli merged 1 commit into from
Mar 22, 2024
Merged

allow schema to be deprecated #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/parser/jsonParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,10 +578,12 @@ function validate(n: ASTNode | undefined, schema: JSONSchema, validationResult:
}

let deprecationMessage = schema.deprecationMessage;
if ((deprecationMessage || schema.deprecated) && node.parent) {
if (deprecationMessage || schema.deprecated) {
deprecationMessage = deprecationMessage || l10n.t('Value is deprecated');
let targetNode = node.parent?.type === 'property' ? node.parent : node;

validationResult.problems.push({
location: { offset: node.parent.offset, length: node.parent.length },
location: { offset: targetNode.offset, length: targetNode.length },
severity: DiagnosticSeverity.Warning,
message: deprecationMessage,
code: ErrorCode.Deprecated
Expand Down
10 changes: 10 additions & 0 deletions src/test/parser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2389,6 +2389,16 @@ suite('JSON Parser', () => {
assert.strictEqual(semanticErrors!.length, 1);
}

schema = {
deprecated: true,
type: 'object'
};
{
const { textDoc, jsonDoc } = toDocument('{"prop": 42}');
const semanticErrors = validate2(jsonDoc, textDoc, schema);
assert.strictEqual(semanticErrors!.length, 1);
}

});

test('Strings with spaces', function () {
Expand Down