Open
Conversation
edvilme
force-pushed
the
phase4/is-match-workspace-root
branch
from
b3f0f6b to
1a59be3
Compare
rchiodo
previously approved these changes
Apr 7, 2026
Contributor
rchiodo
left a comment
rchiodo
left a comment
There was a problem hiding this comment.
Approved via Review Center.
edvilme
force-pushed
the
phase4/is-match-workspace-root
branch
from
1a59be3 to
7b8a28c
Compare
Part of Phase 4 normalization (#465). Adds optional workspace_root=None parameter for signature alignment with mypy. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
edvilme
requested review from
karthiknadig and
rchiodo
and removed request for
karthiknadig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalization change for shared package extraction.
workspace_rootparam tois_match()Backwards-compatible. Default
Nonepreserves existing behavior.