Skip to content

Template Sync: align importStrategy in typescript to python #441

@github-actions

Description

@github-actions

🔄 Template Sync Required

Changes from the upstream vscode-python-tools-extension-template have not yet been incorporated into this repository.

Source PR

Summary

The template updated the default value of importStrategy in getGlobalSettings() from 'fromEnvironment' to 'useBundled' in src/common/settings.ts, to align with the useBundled default used in getWorkspaceSettings() and in package.json. In this repository, getWorkspaceSettings() already uses 'useBundled' as the default (already synced), but getGlobalSettings() still falls back to 'fromEnvironment'.

Files with missing changes

  • src/common/settings.ts: In getGlobalSettings(), line 153, the importStrategy fallback default is still 'fromEnvironment' instead of 'useBundled':
    importStrategy: getGlobalValue(string)(config, 'importStrategy', 'fromEnvironment'),
    This is inconsistent with the workspace settings default ('useBundled') and with the package.json schema default ("useBundled").

Suggested fix

--- a/src/common/settings.ts
+++ b/src/common/settings.ts
@@ -150,7 +150,7 @@ export async function getGlobalSettings(namespace: string, includeInterpreter?:
         interpreter: interpreter ?? [],
-        importStrategy: getGlobalValue(string)(config, 'importStrategy', 'fromEnvironment'),
+        importStrategy: getGlobalValue(string)(config, 'importStrategy', 'useBundled'),
         showNotifications: getGlobalValue(string)(config, 'showNotifications', 'off'),
     };

Files skipped

  • package.json: The flake8.importStrategy default is already "useBundled" in this repository — no change needed.

🤖 This issue was auto-generated by the extension-template-sync workflow.

Generated by Extension Template Sync ·

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions