Add service and scope to query params in addition to headers

[meixnerlu]

Fixes #279

---

I added the option for query parameters to the RequestLike interface and the httpRequest function.
I added the query with service and scope to be send on the token request.
I ran the lint and test commands.

[meixnerlu]

@microsoft-github-policy-service agree

[meixnerlu]

I'm unsure on whether I should add to the changelog while others have open PRs with changes to it.

[bwateratmsft]

I think your approach is good (honestly--probably better than what I did originally), but it goes against the pattern for setting the query params that we use in a few other places in this package. I should probably refactor it later towards your pattern, but for now I'd prefer to keep it consistent with the others. Can you change it to match the pattern below?

Here you can see it being set:

vscode-docker-extensibility/packages/vscode-docker-registries/src/clients/DockerHub/DockerHubRegistryDataProvider.ts

Lines 120 to 122 in 0f54cfc

	let requestUrl: vscode.Uri | undefined = DockerHubRequestUrl
	.with({ path: `v2/repositories/${registry.label}` })
	.with({ query: pageSizeQuery });

And here's how that pageSizeQuery is defined:

vscode-docker-extensibility/packages/vscode-docker-registries/src/clients/DockerHub/DockerHubRegistryDataProvider.ts

Line 32 in 0f54cfc

const pageSizeQuery = new URLSearchParams({ page_size: '100' }).toString();

In the toString for your resultant vscode.Uri, don't forget to pass true, otherwise it gets overencoded.

[meixnerlu]

This looks good but im unsure where you want it implemented. Do you want it implemented for httpRequest or in the function calling it

[bwateratmsft]

I was thinking in the caller of httpRequest.

[bwateratmsft]

Looks good. I'll try to test it out this week.

[bwateratmsft]

Merged, thanks for the contribution @meixnerlu! I'm going to bump the package version and changelog and get it ready to release. Then I'll integrate it into vscode-containers, and it should go out in the upcoming 2.2.0 release.

[meixnerlu]

Thanks its been fun :)