Clean up duplicated code #1751
Merged
Clean up duplicated code #1751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you CCR
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors code to eliminate duplication by consolidating two nearly identical functions (responseFunctionOutputItemToRawContent and responseContentToRawContent) into a single unified function.
Key changes:
- Removed redundant type guard function
isResponseFunctionCallOutputItem - Merged duplicate content conversion logic by updating
responseContentToRawContentto handle bothResponseInputContentandResponseFunctionCallOutputItemtypes - Simplified the image detail handling logic to be more consistent
| url: part.image_url || '', | ||
| detail: part.detail === 'auto' ? | ||
| undefined : | ||
| (part.detail ?? undefined) |
There was a problem hiding this comment.
The expression part.detail ?? undefined is redundant since the nullish coalescing operator will return undefined if part.detail is nullish. This can be simplified to just part.detail as the ternary already handles the 'auto' case.
Suggested change
| (part.detail ?? undefined) | |
| part.detail |
Member
Author
There was a problem hiding this comment.
null -> undefined my friend
Tyriar
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you CCR