Skip to content

Remove Dependency on Newtonsoft.Json from JsonRpc #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025
Merged

Remove Dependency on Newtonsoft.Json from JsonRpc #1201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/StreamJsonRpc/JsonRpc.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1575,7 +1575,7 @@ protected async Task<TResult> InvokeCoreAsync<TResult>(RequestId id, string targ
}
else
{
throw new InvalidOperationException(string.Format(CultureInfo.InvariantCulture, Resources.ResponseUnexpectedFormat, JsonConvert.SerializeObject(response)));
throw new InvalidOperationException(string.Format(CultureInfo.InvariantCulture, Resources.ResponseUnexpectedFormat, response?.GetType().FullName ?? "(null)"));
}
}
else
Expand Down
4 changes: 2 additions & 2 deletions src/StreamJsonRpc/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,8 +288,8 @@
<value>Failed to serialize the response.</value>
</data>
<data name="ResponseUnexpectedFormat" xml:space="preserve">
<value>Response is in an unexpected format. Only error and result are supported: {0}</value>
<comment>{0} is the response message.</comment>
<value>Response is in an unexpected format. Only error and result are supported, but received type: {0}</value>
<comment>{0} is the response object type.</comment>
</data>
<data name="RpcMarshalableDuplicatedOptionalInterface" xml:space="preserve">
<value>Optional interface declarations should be unique. {0} has the same optional interface declared multiple times.</value>
Expand Down