Fix connection hang upon failure to deserialize result values #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteo-prosperi
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a formatter throws an exception from
SetExpectedDataType, the exception was being swallowed, and the request just dangled at the client without ever completing. With this fix, it completes with the exception. Since being unable to serialize a result is a fatal exception, this leads to the connection dying. This is preferable to a hang, and the exception is captured as the cause of the disconnect for later analysis.There is no test because the existing formatters don't throw in this code path. A new formatter might (like the one we're creating for Nerdbank.MessagePack).