Diff findAllReferences
#2605
Merged
Diff findAllReferences
#2605
+1,710
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements baseline diffing for the findAllReferences command in the fourslash test infrastructure. The changes enable proper comparison of findAllReferences test outputs by normalizing and sorting file sections before diffing.
Changes:
- Added
DiffFixupOldprocessing forfindAllReferencesCmdbaseline comparisons - Implemented file section sorting to ensure consistent diff output
- Added logic to filter out test artifacts like context spans and file path prefixes
Reviewed changes
Copilot reviewed 45 out of 400 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/fourslash/baselineutil.go | Adds findAllReferencesCmd case with custom diff preprocessing logic including file section sorting and cleanup |
| testdata/baselines/reference/submodule/fourslash/findAllReferences/*.diff | Updates expected baseline diffs for various findAllReferences test cases showing improved output formatting |
jakebailey
approved these changes
Jan 28, 2026
sheetalkamat
approved these changes
Jan 28, 2026
iisaduan
approved these changes
Jan 29, 2026
mococa
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute find all references baseline diffs to make it easier to review PRs that touch it.