Skip to content

Exclude reparsed nodes from inlay hints #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahejlsberg merged 2 commits into from
Jan 27, 2026
Merged

Exclude reparsed nodes from inlay hints #2593

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08e244a
Exclude reparsed nodes from inlay hints
ahejlsberg Jan 27, 2026
5df0b7c
Merge branch 'main' into fix-2460
ahejlsberg Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/ls/inlay_hints.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ type inlayHintState struct {
}

func (s *inlayHintState) visit(node *ast.Node) bool {
if node == nil || node.End()-node.Pos() == 0 {
if node == nil || node.End()-node.Pos() == 0 || node.Flags&ast.NodeFlagsReparsed != 0 {
return false
Comment on lines 63 to 65
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes a crash on reparsed function expressions, but there is no new regression test covering the scenario from issue #2460 (inlay hints over a reparsed function expression). Given the existing fourslash-based inlay hint tests (e.g. inlayHintsCrash1, inlayHintsTupleTypeCrash), please add a similar fourslash test that exercises a reparsed function expression so future changes don’t reintroduce this panic without being caught by CI.

Copilot generated this review using guidance from repository custom instructions.
Copy link
Member Author

@ahejlsberg ahejlsberg Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a regression test.

}

Expand Down