Skip to content

feat: detect deprecated via JSDoc and flag deprecated property access #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AyomiCoder wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: detect deprecated via JSDoc and flag deprecated property access #2524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions internal/checker/checker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13567,7 +13567,10 @@ func (c *Checker) addErrorOrSuggestion(isError bool, diagnostic *ast.Diagnostic)
}

func (c *Checker) IsDeprecatedDeclaration(declaration *ast.Node) bool {
return c.getCombinedNodeFlagsCached(declaration)&ast.NodeFlagsDeprecated != 0
if c.getCombinedNodeFlagsCached(declaration)&ast.NodeFlagsDeprecated != 0 {
return true
}
return getJSDocDeprecatedTag(declaration) != nil
}

func (c *Checker) addDeprecatedSuggestion(location *ast.Node, declarations []*ast.Node, deprecatedEntity string) *ast.Diagnostic {
Expand Down Expand Up @@ -26283,11 +26286,17 @@ func (c *Checker) getPropertyTypeForIndexType(originalObjectType *Type, objectTy
}
prop := c.getPropertyOfType(objectType, propName)
if prop != nil {
// !!!
// if accessFlags&AccessFlagsReportDeprecated != 0 && accessNode != nil && len(prop.declarations) != 0 && c.isDeprecatedSymbol(prop) && c.isUncalledFunctionReference(accessNode, prop) {
// deprecatedNode := /* TODO(TS-TO-GO) QuestionQuestionToken BinaryExpression: accessExpression?.argumentExpression ?? (isIndexedAccessTypeNode(accessNode) ? accessNode.indexType : accessNode) */ TODO
// c.addDeprecatedSuggestion(deprecatedNode, prop.declarations, propName /* as string */)
// }
if accessFlags&AccessFlagsReportDeprecated != 0 && accessNode != nil && len(prop.Declarations) != 0 && c.isDeprecatedSymbol(prop) && c.isUncalledFunctionReference(accessNode, prop) {
var deprecatedNode *ast.Node
if accessExpression != nil {
deprecatedNode = accessExpression.AsElementAccessExpression().ArgumentExpression.AsNode()
} else if ast.IsIndexedAccessTypeNode(accessNode) {
deprecatedNode = accessNode.AsIndexedAccessTypeNode().IndexType.AsNode()
} else {
deprecatedNode = accessNode
}
c.addDeprecatedSuggestion(deprecatedNode, prop.Declarations, propName /* as string */)
}
if accessExpression != nil {
c.markPropertyAsReferenced(prop, accessExpression, c.isSelfTypeAccess(accessExpression.Expression(), objectType.symbol))
if c.isAssignmentToReadonlyEntity(accessExpression, prop, getAssignmentTargetKind(accessExpression)) {
Expand Down