Fix completion preselection in ternary conditional expressions #2211
+134
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completions within ternary conditionals inside function arguments weren't preselecting the expected type. For example:
Changes
getContextualTypeForConditionalExpressionhelper to get contextual type from parent conditional expressionKindQuestionTokenandKindColonTokencases when parent isConditionalExpressionKindColonTokenwhen not in conditional (preserves object literal, type annotation behavior)The fix uses the parent
ConditionalExpressionnode to locate the containing call expression, enabling proper contextual type inference.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.