Skip to content

Add option for overriding GOMEMLIMIT #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 8 commits into from
Dec 13, 2025
+24 −0
Merged

Add option for overriding GOMEMLIMIT #1808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7f45727
Different approach
maschwenk Oct 3, 2025
e336e76
Merge branch 'main' into mfs-poc-go-memlimit
maschwenk Dec 12, 2025
72e6452
Add pattern
maschwenk Dec 12, 2025
5d58a90
Grr a hallucination
maschwenk Dec 12, 2025
697ec86
Retest the pattern in the code as well
maschwenk Dec 12, 2025
e0f1bb7
Don't throw, just lg error and ignore
maschwenk Dec 13, 2025
d62cbcd
Little helper method to generate env so I don't have to have weird co…
maschwenk Dec 13, 2025
fcac93b
Un-abstract
maschwenk Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions _extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,15 @@
"tags": [
"experimental"
]
},
"typescript.native-preview.goMemLimit": {
"type": "string",
"description": "Set GOMEMLIMIT for the language server (e.g., '2048MiB', '4GiB'). See https://pkg.go.dev/runtime#hdr-Environment_Variables for more information.",
"pattern": "^[0-9]+(([KMGT]i)?B)?$",
"patternErrorMessage": "Must be a valid memory limit (e.g., '2048MiB', '4GiB').",
"tags": [
"experimental"
]
}
}
}
Expand Down
15 changes: 15 additions & 0 deletions _extension/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,16 +103,31 @@ export class Client {
const pprofDir = config.get<string>("pprofDir");
const pprofArgs = pprofDir ? ["--pprofDir", pprofDir] : [];

const goMemLimit = config.get<string>("goMemLimit");
const env = { ...process.env };
if (goMemLimit) {
// Keep this regex aligned with the pattern in package.json.
if (/^[0-9]+(([KMGT]i)?B)?$/.test(goMemLimit)) {
this.outputChannel.appendLine(`Setting GOMEMLIMIT=${goMemLimit}`);
env.GOMEMLIMIT = goMemLimit;
}
else {
this.outputChannel.error(`Invalid goMemLimit: ${goMemLimit}. Must be a valid memory limit (e.g., '2048MiB', '4GiB'). Not overriding GOMEMLIMIT.`);
}
}

const serverOptions: ServerOptions = {
run: {
command: this.exe.path,
args: ["--lsp", ...pprofArgs],
transport: TransportKind.stdio,
options: { env },
},
debug: {
command: this.exe.path,
args: ["--lsp", ...pprofArgs],
transport: TransportKind.stdio,
options: { env },
},
};

Expand Down