Skip to content

Conversation

@manbearian
Copy link
Member

Looks like upstream Triton updated their LLVM reference. The change llvm/llvm-project#71010 removed memref.tensor_store as being redundant. I've updated our refernences to memremf.tensor_store with bufferization.materialize_in_destination as per that PR.

@nhat-nguyen
Copy link
Contributor

oh... I literally did the same thing last night over at nhat/fix_nightly :D I should have put up the PR earlier to save you the time from doing this. Looks good to me. The pipeline will still fail after this unfortunately due to this commit last night when I tested it: triton-lang/triton@72c9833

@nhat-nguyen
Copy link
Contributor

The pipeline keeps failing because git can't checkout the repo at 9f4ad17c22b889d3804d1a1c38ed79b0e936e82. This commit is also ahead of triton-lang/triton@72c9833 which breaks the cpu backend too. Let's use this [BACKEND] Refactor wgmma descriptor creation (https://github.com/openai/triton/pull/2725[)](https://github.com/openai/triton/commit/56c284cf7e39f249cdf1d8d5dba7892deb0286d6), it's right before the backend plugin breaking change.

@manbearian
Copy link
Member Author

@nhat-nguyen next time assign the issue to yourself when you start to take a look :)

@danikhan632 danikhan632 mentioned this pull request Dec 1, 2023
Copy link
Member Author

@manbearian manbearian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Copy link

@NathanielMcVicar NathanielMcVicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manbearian manbearian merged commit 1759426 into main Dec 1, 2023
@manbearian manbearian deleted the dev/ianb/excise-memref-tensor-store-op branch December 1, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants