Skip to content

Conversation

@danikhan632
Copy link
Contributor

No description provided.

@danikhan632
Copy link
Contributor Author

remade the PR here, should work

@nhat-nguyen
Copy link
Contributor

We still have arm-workflow as the target instead of main 😄

@danikhan632
Copy link
Contributor Author

We still have arm-workflow as the target instead of main 😄

think I misunderstood, so you want me to merge to main?

@nhat-nguyen
Copy link
Contributor

Yeah I think we misunderstood. My question in the other thread was to confirm if you wanted to merge to main or the arm-workflow branch. If we want to merge to the arm-workflow, I can help with updating the arm-workflow branch so your PR's diffs won't be too overwhelming.

@danikhan632
Copy link
Contributor Author

Yeah I think we misunderstood. My question in the other thread was to confirm if you wanted to merge to main or the arm-workflow branch. If we want to merge to the arm-workflow, I can help with updating the arm-workflow branch so your PR's diffs won't be too overwhelming.

I think merging to main might be easier then, I know there are memory issues with 1ES crashing when building triton but we can try main

@danikhan632 danikhan632 changed the base branch from nathanielmcvicar/arm-workflow to main February 20, 2024 18:23
@danikhan632
Copy link
Contributor Author

the upstream binaries are updated, can this be re-run?

@aaronsm
Copy link
Contributor

aaronsm commented Feb 29, 2024

the upstream binaries are updated, can this be re-run?

Sure. The tests will probably fail because the triple is defaulting to X64. We need OAI to update the LLVM binaries one more time with my last change.

@aaronsm
Copy link
Contributor

aaronsm commented Feb 29, 2024

@danikhan632 I think the file needs to be formatted

https://github.com/microsoft/triton-shared/actions/runs/8086480662/job/22143942797?pr=103

@danikhan632
Copy link
Contributor Author

@danikhan632 I think the file needs to be formatted

https://github.com/microsoft/triton-shared/actions/runs/8086480662/job/22143942797?pr=103

Think it might have been the line spacing

@aaronsm aaronsm changed the title arm workflow runner Arm64 workflow runner Feb 29, 2024
@aaronsm aaronsm merged commit e3a94ed into microsoft:main Mar 1, 2024
@nhat-nguyen nhat-nguyen mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants