-
Notifications
You must be signed in to change notification settings - Fork 288
Use EasyNamedPipes for dotnet test protocol #6814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
e0be6b8
314999c
ad21b2c
6f38119
b9d0546
053e864
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,17 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| using EasyNamedPipes; | ||
|
|
||
| namespace Microsoft.Testing.Platform.IPC.Models; | ||
|
|
||
| internal sealed record CommandLineOptionMessage(string? Name, string? Description, bool? IsHidden, bool? IsBuiltIn); | ||
| internal sealed record CommandLineOptionMessage( | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we missing the attribute here?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure what's the right policy. If I look at the old serializer only the outer message was marked, the inner message is only an object of the outer. |
||
| [property: PipePropertyId(1)] string? Name, | ||
| [property: PipePropertyId(2)] string? Description, | ||
| [property: PipePropertyId(3)] bool? IsHidden, | ||
| [property: PipePropertyId(4)] bool? IsBuiltIn); | ||
|
|
||
| internal sealed record CommandLineOptionMessages(string? ModulePath, CommandLineOptionMessage[]? CommandLineOptionMessageList) : IRequest; | ||
| [PipeSerializableMessage("DotNetTestProtocol", 3)] | ||
|
||
| internal sealed record CommandLineOptionMessages( | ||
| [property: PipePropertyId(1)] string? ModulePath, | ||
| [property: PipePropertyId(2)] CommandLineOptionMessage[]? CommandLineOptionMessageList) : IRequest; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,26 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| using EasyNamedPipes; | ||
|
|
||
| using Microsoft.Testing.Platform.Extensions.Messages; | ||
|
|
||
| namespace Microsoft.Testing.Platform.IPC.Models; | ||
|
|
||
| internal sealed record DiscoveredTestMessage(string? Uid, string? DisplayName, string? FilePath, int? LineNumber, string? Namespace, string? TypeName, string? MethodName, string[]? ParameterTypeFullNames, TestMetadataProperty[] Traits); | ||
| internal sealed record DiscoveredTestMessage( | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we missing the attribute here? |
||
| [property: PipePropertyId(1)] string? Uid, | ||
| [property: PipePropertyId(2)] string? DisplayName, | ||
| [property: PipePropertyId(3)] string? FilePath, | ||
| [property: PipePropertyId(4)] int? LineNumber, | ||
| [property: PipePropertyId(5)] string? Namespace, | ||
| [property: PipePropertyId(6)] string? TypeName, | ||
| [property: PipePropertyId(7)] string? MethodName, | ||
| [property: PipePropertyId(8)] string[]? ParameterTypeFullNames, | ||
| [property: PipePropertyId(9)] TestMetadataProperty[] Traits); | ||
|
|
||
| internal sealed record DiscoveredTestMessages(string? ExecutionId, string? InstanceId, DiscoveredTestMessage[] DiscoveredMessages) : IRequest; | ||
| [PipeSerializableMessage("DotNetTestProtocol", 5)] | ||
| internal sealed record DiscoveredTestMessages( | ||
| [property: PipePropertyId(1)] string? ExecutionId, | ||
| [property: PipePropertyId(2)] string? InstanceId, | ||
| [property: PipePropertyId(3)] DiscoveredTestMessage[] DiscoveredMessages) | ||
| : IRequest; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,21 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| using EasyNamedPipes; | ||
|
|
||
| namespace Microsoft.Testing.Platform.IPC.Models; | ||
|
|
||
| internal sealed record FileArtifactMessage(string? FullPath, string? DisplayName, string? Description, string? TestUid, string? TestDisplayName, string? SessionUid); | ||
| internal sealed record FileArtifactMessage( | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we missing the attribute here? |
||
| [property: PipePropertyId(1)] string? FullPath, | ||
| [property: PipePropertyId(2)] string? DisplayName, | ||
| [property: PipePropertyId(3)] string? Description, | ||
| [property: PipePropertyId(4)] string? TestUid, | ||
| [property: PipePropertyId(5)] string? TestDisplayName, | ||
| [property: PipePropertyId(6)] string? SessionUid); | ||
|
|
||
| internal sealed record FileArtifactMessages(string? ExecutionId, string? InstanceId, FileArtifactMessage[] FileArtifacts) : IRequest; | ||
| [PipeSerializableMessage("DotNetTestProtocol", 7)] | ||
| internal sealed record FileArtifactMessages( | ||
| [property: PipePropertyId(1)] string? ExecutionId, | ||
| [property: PipePropertyId(2)] string? InstanceId, | ||
| [property: PipePropertyId(3)] FileArtifactMessage[] FileArtifacts) | ||
| : IRequest; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| using EasyNamedPipes; | ||
|
|
||
| namespace Microsoft.Testing.Platform.IPC.Models; | ||
|
|
||
| internal sealed record HandshakeMessage(Dictionary<byte, string>? Properties) : IRequest, IResponse; | ||
| [PipeSerializableMessage("DotNetTestProtocol", 9)] | ||
| internal sealed record HandshakeMessage( | ||
| [property: PipePropertyId(1)] Dictionary<byte, string>? Properties) | ||
| : IRequest, IResponse; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,40 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| using EasyNamedPipes; | ||
|
|
||
| namespace Microsoft.Testing.Platform.IPC.Models; | ||
|
|
||
| internal sealed record SuccessfulTestResultMessage(string? Uid, string? DisplayName, byte? State, long? Duration, string? Reason, string? StandardOutput, string? ErrorOutput, string? SessionUid); | ||
| internal sealed record SuccessfulTestResultMessage( | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here |
||
| [property: PipePropertyId(1)] string? Uid, | ||
| [property: PipePropertyId(2)] string? DisplayName, | ||
| [property: PipePropertyId(3)] byte? State, | ||
| [property: PipePropertyId(4)] long? Duration, | ||
| [property: PipePropertyId(5)] string? Reason, | ||
| [property: PipePropertyId(6)] string? StandardOutput, | ||
| [property: PipePropertyId(7)] string? ErrorOutput, | ||
| [property: PipePropertyId(8)] string? SessionUid); | ||
|
|
||
| internal sealed record FailedTestResultMessage(string? Uid, string? DisplayName, byte? State, long? Duration, string? Reason, ExceptionMessage[]? Exceptions, string? StandardOutput, string? ErrorOutput, string? SessionUid); | ||
| internal sealed record FailedTestResultMessage( | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here |
||
| [property: PipePropertyId(1)] string? Uid, | ||
| [property: PipePropertyId(2)] string? DisplayName, | ||
| [property: PipePropertyId(3)] byte? State, | ||
| [property: PipePropertyId(4)] long? Duration, | ||
| [property: PipePropertyId(5)] string? Reason, | ||
| [property: PipePropertyId(6)] ExceptionMessage[]? Exceptions, | ||
| [property: PipePropertyId(7)] string? StandardOutput, | ||
| [property: PipePropertyId(8)] string? ErrorOutput, | ||
| [property: PipePropertyId(9)] string? SessionUid); | ||
|
|
||
| internal sealed record ExceptionMessage(string? ErrorMessage, string? ErrorType, string? StackTrace); | ||
| internal sealed record ExceptionMessage( | ||
Evangelink marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| [property: PipePropertyId(1)] string? ErrorMessage, | ||
| [property: PipePropertyId(2)] string? ErrorType, | ||
| [property: PipePropertyId(3)] string? StackTrace); | ||
|
|
||
| internal sealed record TestResultMessages(string? ExecutionId, string? InstanceId, SuccessfulTestResultMessage[] SuccessfulTestMessages, FailedTestResultMessage[] FailedTestMessages) : IRequest; | ||
| [PipeSerializableMessage("DotNetTestProtocol", 6)] | ||
| internal sealed record TestResultMessages( | ||
| [property: PipePropertyId(1)] string? ExecutionId, | ||
| [property: PipePropertyId(2)] string? InstanceId, | ||
| [property: PipePropertyId(3)] SuccessfulTestResultMessage[] SuccessfulTestMessages, | ||
| [property: PipePropertyId(4)] FailedTestResultMessage[] FailedTestMessages) | ||
| : IRequest; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,13 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| using EasyNamedPipes; | ||
|
|
||
| namespace Microsoft.Testing.Platform.IPC.Models; | ||
|
|
||
| internal sealed record TestSessionEvent(byte? SessionType, string? SessionUid, string? ExecutionId) : IRequest; | ||
| [PipeSerializableMessage("DotNetTestProtocol", 8)] | ||
| internal sealed record TestSessionEvent( | ||
| [property: PipePropertyId(1)] byte? SessionType, | ||
| [property: PipePropertyId(2)] string? SessionUid, | ||
| [property: PipePropertyId(3)] string? ExecutionId) | ||
| : IRequest; |
Uh oh!
There was an error while loading. Please reload this page.