Repository navigation
Update .NET 12 SDK to 12.0.100-alpha.1.26562.108 - #12464
Conversation
Refresh both global.json pins to the latest public .NET 12 daily SDK and synchronize the opt-in Bazel engineering SDK registration (version, runtime, six archive SHA-512s) and the verifier's compiler/runtime metadata. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🧪 Test quality review — PR #12464
Compared merge base e92578e3a4c076150c8b4174fbe04bd5b9df91d6 with head ee4ff6852b552eae1b6923756eecaf9c4b9aec75. Evidence applies to this head, not every intermediate commit.
Test-value evidence
| Contract | Scenario / expected outcome | Test / assertion | Counterfactual | Status |
|---|---|---|---|---|
Engineering SDK verifier pins the expected compiler identity (5.14.0-1.26562.108) |
A valid compiler fixture from the new SDK must be accepted; a mismatched identity must be rejected | eng/bazel/test-engineering-sdk-verifier.ps1 fixtures (existing, expected values updated in this PR) |
Old verifier with the new SDK would reject the new compiler identity | Static prediction. The PR description reports an executed before/after run, but no accessible record matches this head's variants. |
| SDK pins, archive SHA-512 values, docs | Pin values must match the published SDK build | None (data values) | Not applicable | Not applicable (validated by build and Bazel runs per the author, not verified here) |
No test methods or parallelization configuration changed. Nothing was executed in this workflow.
🧵 Parallel safety
NOT_APPLICABLE. No changed tests or parallelization configuration were in scope.
Per-test assessment
Not applicable. No test methods were changed (the verifier script is PowerShell, not a graded C# test method).
No inline findings. Archive checksum values were not independently verified against the published checksums.
<sub>This advisory review is heuristic and non-blocking.
Re-run the combined review with /review-tests, or only the parallel-safety specialist with /parallel-audit.</sub>
🤖 Automated content by GitHub Copilot. Generated by the Test Quality Review on PR (on open / sync) workflow. · copilot · auto · ~27 AIC · ⌖ ~1 AIC · ⊞ 8.1K
There was a problem hiding this comment.
Note
🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
Summary: no blocking findings.
Checked:
global.json(both pins),engineering-sdk.bzl(_SDK_VERSION/_RUNTIME_VERSION),verify-engineering-sdk.ps1(commit8b22ce04..., compiler5.14.0-1.26562.108, runtime) and the verifier self-test fixtures all use26562.108. I found no stale26556.115in any.bzl,.ps1,.json,.yml,.propsor.bazelfile.- The six SHA-512 values are well-formed 128-hex strings and all changed. I could not independently fetch the ci.dot.net manifests, so correctness of the hashes rests on the PR's stated verification.
docs/bazel.mdnow cites the exactglobal.jsonSDK. It was already stale (26509.101), so this is a good fix.
Non-blocking notes:
- Older sections (
docs/affected-test-selection.mdlines ~98, 236, 319, and severaldocs/decisions/*.mdfiles) still say26556.115. They read as dated validation records, so leaving them is reasonable. The phrase "repository-pinned SDK" inaffected-test-selection.md~236 and ~319 is now slightly ambiguous, though. - The PR says CI was not run and affected-test paths were not re-exercised end to end. Please rely on CI for that.
Test-value evidence: behavior-preserving version bump. The PR reports 12 verifier fixtures passing, plus the old-versus-new verifier comparison. I did not execute these (read-only review of untrusted PR code).
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the repository SDK and opt-in Bazel toolchain refresh.
No open issues 🎉
What changed in this PR
Refreshes TestFx’s repository SDK and opt-in Bazel engineering toolchain to .NET SDK 12.0.100-alpha.1.26562.108, continuing the previous SDK refresh without changing product APIs or default Bazel tooling.
Changes:
- Updates both repository SDK pins and Bazel’s engineering SDK/runtime pins and six archive checksums.
- Synchronizes compiler-verifier expectations and fixtures.
- Updates documentation with the current pin and validation evidence.
Test-value evidence: The PR reports that, at revision ee4ff6852b552eae1b6923756eecaf9c4b9aec75, the previous verifier rejects the new compiler while the updated verifier accepts identical input; all 12 fixtures pass. These results were not independently executed here. CI, non-Windows native execution, and affected-test end-to-end validation remain unverified.
| File | Description |
|---|---|
global.json |
Updates both repository SDK pins. |
eng/bazel/verify-engineering-sdk.ps1 |
Updates expected compiler commit, identity, and runtime. |
eng/bazel/test-engineering-sdk-verifier.ps1 |
Aligns verifier fixtures with the new SDK. |
eng/bazel/engineering-sdk.bzl |
Updates engineering SDK/runtime versions and six archive checksums. |
docs/decisions/bazel-build.md |
Records refresh rationale, validation, and limitations. |
docs/bazel.md |
Corrects the documented engineering SDK pin. |
docs/affected-test-selection.md |
Records validator results and end-to-end validation limits. |
Review effort: Balanced
|
Preliminary test-triage analysis — Azure Pipelines build 1679959 Preliminary: the build is still running, so other legs may change this conclusion. Affected leg: Failures (
Assessment (confidence: medium):
Next step: check how
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🧪 Test quality review — PR #12464
Compared merge base 2cf92e4e5a532c91adb1035b52969fa8ad944a50 with head 6610464d2cb7c9879954afbcc5342b53ce95927a. Evidence applies to this head, not every intermediate commit.
Test-value evidence
| Contract | Scenario / counterfactual | Result |
|---|---|---|
Engineering SDK pin bump (global.json, eng/bazel/engineering-sdk.bzl, verifier scripts, docs) |
The SDK/runtime version, archive checksums and compiler commit move together from 26556.115 to 26562.108. A mismatch would be caught by verify-engineering-sdk.ps1, which checks the compiler version and commit, and by the verifier fixtures in test-engineering-sdk-verifier.ps1. |
Not applicable for new regression tests (data/config bump). Static prediction only: the verifier would detect a version/commit mismatch. Nothing was executed. |
Gap: I did not check that the new checksums or the commit 8b22ce04... match the published SDK. That needs a CI run of the Bazel verifier.
🧵 Parallel safety
PARALLEL-SAFETY RESULT
STATUS: NOT_APPLICABLE
ASSEMBLIES:
none
COUNTS: A=0; B=0; C=0; D=0; Critical=0; High=0; Warning=0; Info=0
TOP_ACTIONS:
none
FINDINGS:
none
NOTES: No changed tests or parallelization configuration were in scope.
END PARALLEL-SAFETY RESULT
Per-test assessment
No test methods changed, so there is nothing to grade (Not applicable).
<sub>This advisory review is heuristic and non-blocking.
Re-run the combined review with /review-tests, or only the parallel-safety specialist with /parallel-audit.</sub>
🤖 Automated content by GitHub Copilot. Generated by the Test Quality Review on PR (on open / sync) workflow. · copilot · auto · ~26 AIC · ⌖ ~1 AIC · ⊞ 8.1K
Pull request
Summary
Refreshes the repository's .NET 12 SDK pin to the newest public .NET 12 daily build,
12.0.100-alpha.1.26562.108(runtime12.0.0-alpha.1.26562.108, commit8b22ce04ad5fa175ef5cd8f96c38fcba40e173dc), following the same pattern as the previous refresh (#12270).global.json: bothtools.dotnetandsdk.versionpins.eng/bazel/engineering-sdk.bzl: opt-in Bazel engineering SDK version, runtime, and all six host archive SHA-512 values (win/linux/osx x x64/arm64), checked againsthttps://ci.dot.net/public-checksums/Sdk/12.0.100-alpha.1.26562.108/.eng/bazel/verify-engineering-sdk.ps1andeng/bazel/test-engineering-sdk-verifier.ps1: expected SDK commit, compiler identity (5.14.0-1.26562.108 (8b22ce04...)), and runtime version.docs/bazel.md: current pin.docs/decisions/bazel-build.mdanddocs/affected-test-selection.md: refresh evidence records.Unchanged: Arcade SDK, the
global.jsonruntimes (10.0.15, 11.0.0), the default published SDK 11 used by Bazel CI, the SDK 10.0.401 bootstrap, the independently pinned net8/9/10/11 reference packs, and the affected-tests minimum SDK gate (the new SDK satisfies it). Historical SDK versions in decision records are evidence and were intentionally not rewritten.Design and decision record
Routine dependency refresh; no new design. The evidence is recorded in docs/decisions/bazel-build.md - SDK pin refresh (2026-11-13), and a short note was added to docs/affected-test-selection.md.
The latest build was selected via the public
https://aka.ms/dotnet/12.0.1xx/daily/productCommit-<rid>.txtlinks, which point every host to the same 26562.108 build.Demonstration
N/A. This is an SDK pin refresh with no user-visible output change. Validation evidence is below.
Validation and regression proof
All runs used source state
ee4ff6852b552eae1b6923756eecaf9c4b9aec75(or its identical uncommitted equivalent) on Windows x64 with the SDK restored into.dotnet/..\eng\build.ps1 -restore -buildSystem.Security.Cryptography.Pkcs9.0.6 inMSTest.Analyzers.UnitTests. No new analyzer diagnostics.pwsh -NoProfile -File .\eng\bazel\test-engineering-sdk-verifier.ps1 -EngineeringSdkDirectory .dotnet -PublishedSdkDirectory "C:\Program Files\dotnet".\eng\bazel.ps1 build //:platform --extra_toolchains=@dotnet_engineering_toolchains//:all.\eng\bazel.ps1 test //:protocol_contract_tests //:simple1_test --extra_toolchains=@dotnet_engineering_toolchains//:all --nocache_test_results//:protocol_contract_tests28 cases passed and//:simple1_test1 case passed, with fresh TRX results on the .NET 12 host..\eng\bazel.ps1 aquery 'deps(set(//:platform //:protocol_contract_tests //:simple1_test))' --extra_toolchains=... --include_param_files --output=jsonprotothenverify-engineering-sdk.ps1 -ActionGraph ... -ExecutionRoot ... -TargetFrameworks net10.0net10.0reference pack stays 10.0.14. (-TargetFrameworks net10.0is required because these targets compile only that framework.)pwsh -NoProfile -File .\eng\validate-affected-tests.ps1 -SelfTest -EnableAffectedTests true -EnableNonWindowsAffectedTests falseand the same withfalse/trueSDK identity was checked directly:
csc -versionreports5.14.0-1.26562.108 (8b22ce04ad5fa175ef5cd8f96c38fcba40e173dc), the compiler runtimeconfig requests runtime12.0.0-alpha.1.26562.108, the bundled max/default target framework isnet12.0, and the default language versions are C# 15.0 and F# 11.2.Not run or not covered:
build.cmd/dotnet-install, so PATH was deduplicated in-process before running the commands above. That is a host issue, not related to this change.Test-value evidence
The executable contract affected here is the engineering SDK verifier, which pins the exact compiler identity it accepts.
eng/bazel/verify-engineering-sdk.ps1blob1d6497f20cd2d11ac088a4b516c1bd54a1ec6548, was run from an isolated copy with the newglobal.jsonagainst the valid four-frameworkVerifiedEngineeringCompilerfixture and the real new compiler. It exited 1 withUnexpected compiler identity: 5.14.0-1.26562.108 (8b22ce04...)after the compiler itself exited 0.So the metadata update is required, and the verifier still rejects a mismatched SDK. The remaining changes are pin values validated by the build and the native Bazel runs above.