Skip to content

[main] Update dependencies from microsoft/testfx - #12333

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
darc-main-9878dba0-c6dd-425c-95eb-9425a9aea143
Nov 11, 2026
Merged

Amaury Levé (Evangelink) merged 2 commits into
mainfrom
darc-main-9878dba0-c6dd-425c-95eb-9425a9aea143

Conversation

@dotnet-maestro

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/microsoft/testfx

…261110.13

On relative base path root
Microsoft.Testing.Platform From Version 3.0.0-preview.26559.7 -> To Version 3.0.0-preview.26560.13
MSTest From Version 5.0.0-preview.26559.7 -> To Version 5.0.0-preview.26560.13
Copilot AI balanced review requested due to automatic review settings November 11, 2026 02:03
@github-actions
github-actions Bot enabled auto-merge (squash) November 11, 2026 02:03
@github-actions github-actions Bot added the state/needs-review Awaiting review from the team. label Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the MSTest and Microsoft.Testing.Platform dependency updates.

No open issues 🎉

What changed in this PR

Updates the repository’s MSTest and Microsoft.Testing.Platform dependencies to the versions produced by upstream build 20261110.13.

Changes:

  • Bumps MSTest to 5.0.0-preview.26560.13 and Microsoft.Testing.Platform to 3.0.0-preview.26560.13.
  • Synchronizes dependency records with upstream commit ce9458dbf1203895f8abeeb1697f12e16232aa88.
File Description
eng/​Versions.props Updates the MSTest and Microsoft.Testing.Platform version properties.
eng/​Version.Details.xml Aligns dependency versions and source commit hashes with the upstream build.

Review effort: Balanced

Copilot AI commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Build the repository

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

@microsoft-github-policy-service microsoft-github-policy-service Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approve

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Build Failure Analysis

Summary — the MSTest dependency update activates MSTEST0037 as a build error, causing 39 existing collection-wide Assert.IsTrue(...All(...)) assertions to fail compilation across all three available build legs.

Root cause: new analyzer enforcement from the MSTest package flow

The PR updates MSTest from 5.0.0-preview.26559.7 to 5.0.0-preview.26560.13. With the updated analyzer, collection predicates written as Assert.IsTrue(collection.All(predicate)) are rejected in CoreCompile; the analyzer requires the dedicated Assert.ContainsOnly(predicate, collection) API. The same source locations fail on Linux Release, Windows Debug, and Windows Release, so these are one analyzer-migration root cause rather than independent compiler failures.

Affected files / errors

Every diagnostic is:

MSTEST0037: Use 'Assert.ContainsOnly' instead of 'Assert.IsTrue'

Proposed fix

Apply the MSTest analyzer code fix to the 39 reported locations, preserving any existing assertion message:

- Assert.IsTrue(collection.All(predicate));
+ Assert.ContainsOnly(predicate, collection);

The failing files are not part of this dependency-only PR diff, so GitHub inline suggestions cannot target them. I did not request an automated fix commit because the failed Windows application-model acceptance leg published no binlog; the available evidence is therefore incomplete and that leg may contain additional locations that must be migrated in the same change.

Build overview
Leg Result MSBuild errors Failed compile projects
Linux Release Failed 69 (including duplicate emissions) 4 test projects
Windows Debug Failed 121 (including duplicate emissions) 4 test projects
Windows Release Failed 121 (including duplicate emissions) 4 test projects
Windows application-model acceptance Failed Unknown Binlog missing

All available logs identify CoreCompile / Csc as the failing target/task and contain 39 distinct MSTEST0037 source locations. See the [Azure DevOps build]((dev.azure.com/redacted) for the missing leg's authoritative logs.

Distinct MSBuild errors (39)
Code Project Distinct locations Message
MSTEST0037 Microsoft.Testing.Platform.Acceptance.IntegrationTests 10 Use Assert.ContainsOnly instead of Assert.IsTrue
MSTEST0037 Microsoft.Testing.Extensions.UnitTests 23 Use Assert.ContainsOnly instead of Assert.IsTrue
MSTEST0037 Microsoft.Testing.Extensions.VSTestBridge.UnitTests 2 Use Assert.ContainsOnly instead of Assert.IsTrue
MSTEST0037 Microsoft.Testing.Platform.UnitTests 4 Use Assert.ContainsOnly instead of Assert.IsTrue

🤖 Generated by the Build Failure Analysis workflow using (a href="(dev.azure.com/redacted) · commit a9ef1cc

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · copilot · gpt56 · ~135 AIC · ⌖ ~14 AIC · ⊞ 35.4K · ◷

@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Nov 11, 2026
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/needs-review Awaiting review from the team. labels Nov 11, 2026
Copilot AI balanced review requested due to automatic review settings November 11, 2026 09:01
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/approved Proposal approved; ready for implementation. labels Nov 11, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Test quality review — PR #12333

Compared merge base 7d5d0508fd6984bf37d0eee47ba7dfc2443febbe with head a7bcae4e26263d3490c621fb3f64a7113f8f393c. Evidence applies to this head, not every intermediate commit.

Test-value evidence

Contract Evidence Result
Dependency version bump in eng/Version.Details.xml and eng/Versions.props No behavioral change in shipped source or tests not applicable

No execution evidence was generated; this workflow is static and read-only.

🧵 Parallel safety

STATUS: NOT_APPLICABLE. No changed tests or parallelization configuration were in scope.

Per-test assessment

No test methods changed, so there is nothing to grade (Not applicable).

<sub>This advisory review is heuristic and non-blocking.

Re-run the combined review with /review-tests, or only the parallel-safety specialist with /parallel-audit.</sub>

🤖 Automated content by GitHub Copilot. Generated by the Test Quality Review on PR (on open / sync) workflow. · copilot · auto · ~17 AIC · ⌖ ~1 AIC · ⊞ 8.1K

@microsoft-github-policy-service microsoft-github-policy-service Bot added the state/needs-review Awaiting review from the team. label Nov 11, 2026
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/needs-review Awaiting review from the team. state/approved Proposal approved; ready for implementation. labels Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The MSTest and Microsoft.Testing.Platform dependency updates have no active review issues.

No open issues 🎉

Review effort: Balanced

Copilot AI commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Build the repository

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

@Evangelink
Amaury Levé (Evangelink) merged commit ecee016 into main Nov 11, 2026
25 of 34 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the darc-main-9878dba0-c6dd-425c-95eb-9425a9aea143 branch November 11, 2026 09:30
@github-actions github-actions Bot removed the state/approved Proposal approved; ready for implementation. label Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants