Improve TSF color filtering logic (re: QQPinyin) #19117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
carlos-zamora
approved these changes
Jul 14, 2025
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
Looks good to me. The way he handle underline seems right too, since we're currently treating this block as "apply styling if foreground and background styling type matches", so just extending that reasoning to underline makes sense to me.
DHowett
approved these changes
Jul 14, 2025
DHowett
pushed a commit
that referenced
this pull request
Jul 29, 2025
If an IME provider sets both `crText` and `crBk` we should respect this, but the previous logic would incorrectly assert for `crLine != TF_CT_NONE`. ## Validation Steps Performed ❌ I'm not aware which TSF even sets these colors in a way that's compatible with us in the first place... (cherry picked from commit f2b30b4) Service-Card-Id: PVTI_lADOAF3p4s4Axadtzgck4T0 Service-Version: 1.23
DHowett
pushed a commit
that referenced
this pull request
Jul 29, 2025
If an IME provider sets both `crText` and `crBk` we should respect this, but the previous logic would incorrectly assert for `crLine != TF_CT_NONE`. ## Validation Steps Performed ❌ I'm not aware which TSF even sets these colors in a way that's compatible with us in the first place... (cherry picked from commit f2b30b4) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgck4T8 Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an IME provider sets both
crTextandcrBkwe should respect this,but the previous logic would incorrectly assert for
crLine != TF_CT_NONE.Validation Steps Performed
❌ I'm not aware which TSF even sets these colors in a
way that's compatible with us in the first place...