Skip to content

eslint-formatter-sarif "suppressions" can include duplicate items that causes sarif uploading issues #86

@martgil

Description

@martgil

Hello Team,

I'd like to report an issue when the eslint-formatter-sarif suppressions can include duplicate items from which uploading sarif files to fail.

Error we received on https://github.com/FlowCrypt/flowcrypt-browser/actions/runs/9240112388/job/25420029132:

image

Rrror in plain text:
Run github/codeql-action/upload-sarif@v3
Uploading results
Error details: instance.runs[0].results[[8](https://github.com/FlowCrypt/flowcrypt-browser/actions/runs/9240112388/job/25420029132#step:6:9)01].suppressions contains duplicate item
Error details: instance.runs[0].results[803].suppressions contains duplicate item
Error details: instance.runs[0].results[805].suppressions contains duplicate item
Error: Unable to upload "eslint-results.sarif" as it is not valid SARIF:
- instance.runs[0].results[801].suppressions contains duplicate item
- instance.runs[0].results[803].suppressions contains duplicate item
- instance.runs[0].results[805].suppressions contains duplicate item
ConfigurationError: Unable to upload "eslint-results.sarif" as it is not valid SARIF:
- instance.runs[0].results[801].suppressions contains duplicate item
- instance.runs[0].results[803].suppressions contains duplicate item
- instance.runs[0].results[805].suppressions contains duplicate item
    at run (/home/runner/work/_actions/github/codeql-action/v3/lib/upload-sarif-action.js:70:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async runWrapper (/home/runner/work/_actions/github/codeql-action/v3/lib/upload-sarif-action.js:84:9)

So for us to proceed into fixing the issue temporarily on our side, we'll have to update the code for populating the suppressions - FlowCrypt/flowcrypt-browser@876c442#diff-309b09cf37242b8d5d9b63644d18bb3b386d6dc257ea0be89f3fff0e61718979R196-R216

Other than this, the formatter is working so well. Thank you!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions