Skip to content

fix(cli): ensure host is set when starting dev server #3843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
Merged

fix(cli): ensure host is set when starting dev server #3843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/clean-spoons-push.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@rnx-kit/cli": patch
---

Ensure `host` is set to `localhost` by default when starting the dev server,
otherwise it will listen to external connections.
8 changes: 7 additions & 1 deletion packages/cli/src/start.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ export async function rnxStart(
}
}

// CVE-2025-11953: Ensure `host` is set to `localhost` by default, otherwise
// it will listen to external connections.
if (!args.host) {
args.host = "127.0.0.1";
}

// load Metro configuration, applying overrides from the command line
const metroConfig = await loadMetroConfig(ctx, {
...args,
Expand Down Expand Up @@ -109,7 +115,7 @@ export async function rnxStart(

// create middleware -- a collection of plugins which handle incoming
// http(s) requests, routing them to static pages or JS functions.
const host = args.host?.length ? args.host : "localhost";
const host = args.host;
const devServerUrl = `${scheme}://${host}:${port}`;
const devServer = createDevServerMiddleware({ host, port, watchFolders });

Expand Down