-
Notifications
You must be signed in to change notification settings - Fork 262
feat: Fix dropreason for Linux 6.10+ #1907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ea79e10 to
7c53820
Compare
7c53820 to
2e42983
Compare
7a0fd8b to
a78463a
Compare
| struct sock *retsk = NULL; | ||
|
|
||
| int offset; | ||
| if (bpf_core_type_exists(struct proto_accept_arg)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting this part right requires some extensive testing. It would be good to have this covered by some form of automated tests to make sure code from those probes work as expected.
nddq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@invidian please empty out all of the object binaries. The reason we have those in there is for the linter to not complain since those are being embedded in the generated ebpf go files. Also, in terms of updating the vmlinux.h, we will open a PR from our side. Just to confirm, the vmlinux.h changes were from libbpf upstream correct? Or did you include any custom changes from elsewhere as well
a78463a to
d87dd7e
Compare
|
Thanks for reviewing. I removed binary files from the PR. At the moment |
This patch updates the bpf header files, as well as introduce Make commands to help updating these files in the future. Also update the Dockerfile for building the agent and generating Go codes. Signed-off-by: Quang Nguyen <[email protected]>
See microsoft#1906 for details. Signed-off-by: Mateusz Gozdek <[email protected]>
d87dd7e to
8f63bdc
Compare
Description
This PR updates
vmlinux.hto includestruct proto_accept_argfrom Linux 6.10+ (torvalds/linux@92ef0fd) and then makes use of it in dropreason plugin to make plugin compatible with both kernels 6.10+ and older usingbpf_core_type_exists.Related Issue
#1906
Checklist
git commit -S -s ...). See this documentation on signing commits.Additional Notes
Done.vmlinux.hstill needs to be regenerated for arm64 which I'll try to soon.Also, I need to test those changes back on kernel 6.6 to make sure it's still working
Also, I am not aware if this change is covered by unit tests which would detect the regressions.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.