Native driver persists animated values after they're no longer applied

[Thristhart]

Environment

1. react-native -v:

react-native-cli: 2.0.1
react-native: 0.60.6

2. npm ls rnpm-plugin-windows:

rnpm-plugin-windows@0.3.7

3. npm ls react-native-windows:

react-native-windows@0.60.0-vnext.37

4. node -v:

v10.15.0

5. npm -v:

6.4.1

Then, specify:

• Target Platform Version(s): 10.0.18362

• Target Device(s): Desktop, Xbox

• Visual Studio Version: 2019

• Build Configuration: Debug and Release

Steps to Reproduce

1. Pass a style to an Animated.View that contains a transform or opacity set to an Animated.Value
2. Use Animated.timing to animate that Animated.Value to a new value, with useNativeDriver: true
3. Update the Animated.View such that it no longer has the Animated.Value in its styles

Expected Behavior

The transform or opacity would reset to initial values. A View translated to the right previously would have that translation removed.

Actual Behavior

The transform or opacity remain applied, even though the style no longer contains those values.

Reproducible Demo

import React from "react";
import { Animated, Easing, Text, TouchableOpacity } from "react-native";

export default class AnimationPersistRepro extends React.Component {
    state = { animated: false };
    translateXAnimated = new Animated.Value(0);
    onPress = () => {
        this.setState((state) => {
            const shouldAnimate = !state.animated;
            if (shouldAnimate) {
                Animated.timing(this.translateXAnimated, {
                    duration: 400,
                    toValue: 100,
                    easing: Easing.linear,
                    useNativeDriver: true,
                }).start();
            }
            return { animated: shouldAnimate };
        });
    };
    render() {
        const animatedStyle = {
            transform: [{ translateX: this.translateXAnimated }],
        };
        const nonAnimatedStyle = {
            transform: [],
        };
        return (
            <>
                <Animated.View style={this.state.animated ? animatedStyle : nonAnimatedStyle}>
                    <Text>Animates to the right</Text>
                </Animated.View>
                <TouchableOpacity onPress={this.onPress}>
                    <Text>Press to toggle animation. Currently animated: {this.state.animated.toString()} </Text>
                </TouchableOpacity>
            </>
        );
    }
}

----alternative repro as a function component-----

const AnimationPersistRepro = () => {
  const [isAnimated, setAnimated] = useState(false);
  const translateXAnimated = useRef(new Animated.Value(0));

  const animatedStyle = {
    transform: [ { translateX: translateXAnimated.current } ]
  };
  const nonAnimatedStyle = {
    transform: []
  };

  const onPress = () => {
    setAnimated(animated => {
      const shouldAnimate = !animated;
      if(shouldAnimate) {
        Animated.timing(translateXAnimated.current, {
          duration: 400,
          toValue: 100,
          easing: Easing.linear,
          useNativeDriver: true
        }).start();
      }
      return shouldAnimate;
    });
  };

  return (
    <>
      <Animated.View style={isAnimated ? animatedStyle : nonAnimatedStyle}>
        <Text>Animates to the right</Text>
      </Animated.View>
      <TouchableOpacity onPress={onPress}>
        <Text>Press to toggle animation. Currently animated: {isAnimated.toString()} </Text>
      </TouchableOpacity>
    </>
  );
};

[chrisglein]

Interesting scenario. It's not immediately clear whether this is or is not expected behavior, as in what sort of memory do animations have. First step would be to try this on Android/iOS to clarify that expected behavior.

[kmelmon]

Confirmed in snack this isn't expected behavior for other platforms.

[Thristhart]

I assume this is related to #3280, given that #3281 comments out target.StopAnimation()

[chrisglein]

Comment from @marlenecota:

Debugged issue #3460 where an animated View is not reset after the animation is removed. There’s a lot of Animated code, so it’s going to take a little time to figure out how they all work together, but it looks like there’s an unimplemented “ResetDefaultValues” function in PropsAnimatedNode that needs to be called when it is disconnected from the View. Unfortunately the original value is not stored anywhere, so I am trying to figure out where it would go. I spoke with the Xbox guys and they have a workaround for this, so it is not currently blocking and are ok waiting for a fix.

Given presence of workaround, moving this to M5.