chore(control-or-meta): mention in docs #33338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
reviewed
Oct 29, 2024
| // on macOS | ||
| await page.keyboard.press('Meta+A'); | ||
| // cross-platform | ||
| await page.keyboard.press('ControlOrMeta+A'); |
Contributor
There was a problem hiding this comment.
lets move it up two positions or nuke Control/Meta entirely.
This comment has been minimized.
This comment has been minimized.
mxschmitt
approved these changes
Oct 29, 2024
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"2 flaky36697 passed, 630 skipped Merge workflow run. |
YusukeIwaki
added a commit
to YusukeIwaki/playwright-ruby-client
that referenced
this pull request
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33335