fix(types): revert type changes made to support TS 5.5 #32066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes broke chaining of `extend`s where the first `extend` did not specify any type arguments.
mxschmitt
approved these changes
Aug 8, 2024
Contributor
Test results for "tests 1"1 failed 3 flaky29651 passed, 714 skipped Merge workflow run. |
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Aug 8, 2024
… support TS 5.5 Regressed in microsoft#31532. The TS5.5 changes broke chaining of `extend`s where the first `extend` did not specify any type arguments. Fixes microsoft#32056.
dmlemeshko
added a commit
to elastic/kibana
that referenced
this pull request
Dec 3, 2024
## Summary Since the new Kibana test framework has a strong dependency on `@playwright/test`, moving it under appex-qa ownership I had to update and explicitly specify types when extending the pre-existing fixtures as there was a bug fix enforcing it microsoft/playwright#32066
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Since the new Kibana test framework has a strong dependency on `@playwright/test`, moving it under appex-qa ownership I had to update and explicitly specify types when extending the pre-existing fixtures as there was a bug fix enforcing it microsoft/playwright#32066
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed in #31532. The TS5.5 changes broke chaining of
extends where the firstextenddid not specify any type arguments.Fixes #32056.