fix(tracing): avoid clashing network file names #22126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
Mar 31, 2023
With two contexts in the same test, we can get: - `<testId>.network` and `<testId>-1.network` files; - for export, we can copy `<testId>.network` into `<testId>-1.network` and try to copy into a file when another trace is reading from it.
dgozman
force-pushed
the
fix-tracing-clashing-network
branch
from
c72fc2a to
9ddeb04
Compare
dgozman
added a commit
that referenced
this pull request
Apr 1, 2023
With two contexts in the same test, we can get: - `<testId>.network` and `<testId>-1.network` files; - for export, we can copy `<testId>.network` into `<testId>-1.network` and try to copy into a file when another trace is reading from it. Fixes #22089.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With two contexts in the same test, we can get:
<testId>.networkand<testId>-1.networkfiles;<testId>.networkinto<testId>-1.networkand try to copy into a file when another trace is reading from it.Fixes #22089.