Enable W4 and warnings as errors for C++ projects - #2441
Merged
Brian Robbins (brianrob) merged 2 commits intoJul 16, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5b148be3-5dce-425e-b025-94eb7b8de1d5
Matt Connew (mconnew)
previously approved these changes
Jul 15, 2026
Matt Connew (mconnew)
left a comment
Matt Connew (mconnew)
left a comment
Member
There was a problem hiding this comment.
Just one small bit of potential cleanup related to one of the cleaned up lines.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5b148be3-5dce-425e-b025-94eb7b8de1d5
Matt Connew (mconnew)
approved these changes
Jul 15, 2026
Brian Robbins (brianrob)
enabled auto-merge (squash)
July 15, 2026 23:08
This was referenced Jul 18, 2026
Open
Merged
This was referenced Jul 25, 2026
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables /W4 and /WX for both ETW CLR profiler projects and fixes the resulting warnings.